Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comment about linting #11

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Conversation

laserlab
Copy link
Contributor

@laserlab laserlab commented Nov 1, 2024

Added a comment about linting in the PR template

Contents

  • added a comment that the linting result should be checked
  • pull request template

Reviewer

Added a comment about linting in the PR template
@laserlab laserlab added this to the Homework 5 milestone Nov 1, 2024
Copy link
Collaborator

@SchrodingersStruggle SchrodingersStruggle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling/grammar to check in my comment.

docs/pull_request_template.md Outdated Show resolved Hide resolved
@laserlab
Copy link
Contributor Author

laserlab commented Nov 2, 2024

@SchrodingersStruggle jst fixed the typos. Ready to merge

Copy link
Collaborator

@SchrodingersStruggle SchrodingersStruggle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@SchrodingersStruggle SchrodingersStruggle merged commit 8bb4352 into main Nov 2, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants