-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo setup #10
Repo setup #10
Conversation
Added standard devcontainer seen in our previous homeworks.
Added essential items to requirements.txt
Used pylint as I (personally) find it nicer to work with than Flake8. Got the file from the midterm repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good,
check for my comment about splitting the linting / testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the last Homework we had that separated. You can talk to @kylemasc917 and @HeshamElsaman if that was more convenient. I would merge it like this for now though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not separating them would be better, not 100% sure, though.
I'd suggest not separating them and adding comments to the .yaml file..
@kylemasc917 If I were to separate the linting and pytest, would I need to clear the cache of pylint like in flake 8, or would that not be necessary? |
Not that I know of, but you'll have to test it out and see. |
Okay I will keep them merged for now, as suggested by @laserlab, and merge this request so people can work with linting in the repository. |
Initial setup for repository
Contents
Label:
Reviewer