Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

fix: use tar options to enable extraction on F40 based source #15

Merged
merged 26 commits into from
May 2, 2024

Conversation

bsherman
Copy link
Collaborator

@bsherman bsherman commented May 1, 2024

This should get us past the build issue where tar fails to extract files on old podman.

Fixes: ublue-os/ucore#160

@bsherman bsherman requested a review from m2Giles May 1, 2024 18:04
@bsherman
Copy link
Collaborator Author

bsherman commented May 1, 2024

I do expect testing builds to still fail since zfs 2.2.4 is not yet merged with support for kernel 6.8.

openzfs/zfs#16107

I'm surprised stable works as it upgraded to 6.8.4.

@bsherman
Copy link
Collaborator Author

bsherman commented May 1, 2024

@bsherman bsherman requested review from m2Giles and p5 May 2, 2024 17:50
.github/workflows/build.yml Outdated Show resolved Hide resolved
@bsherman
Copy link
Collaborator Author

bsherman commented May 2, 2024

The solution which has finally worked is to use docker buildx instead of buildah and podman push.

Other than swapping a two redhat actions for a single docker action, the main difference is piping our already generated tag list into the docker/metadata action so that the tags are docker/build-and-push friendly.

Side benefit, we can actually see what tags/registries we expect to push in the log out put for the metadata, even if not pushing.

build-kmod-zfs.sh Show resolved Hide resolved
Copy link
Member

@p5 p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bsherman bsherman merged commit f2cd6e1 into main May 2, 2024
3 checks passed
@bsherman bsherman deleted the tar-f40-fix branch May 2, 2024 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zfs kmod build fails due to tar Operation not permitted on testing/F40
3 participants