-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cat to replace bat #67
Comments
Hi @castrojo, would like to make first contribution but don't know what to do with this one. |
|
hey @m2Giles, thanks a lot for taking the time to answer !
I know you already broke it down for me but I would greatly appreciate if you could give me an even more detailed road map 😃 |
Yepp. Git clone the repo. Make the changes and the build the container using buildah. Test the container and if everything is good submit a pull request. |
Thanks @m2Giles. Alright, so I think I have the 2 first steps ready:
I added the line
I added # Bat for cat
alias cat='bat --style=plain' 2>/dev/null in
Now I'm not sure how to build the container using buildah. I would appreciate any hint (link, advice...) to finish this. thanks |
@bitsByB I'm not a maintainer here, stumbled on this looking for something else, but I think I can help with one or two things. I am very likely overexplaining some parts. I assume it's more helpful to risk overexplaination than assume "common" knowledge -- feel free to skim things you already know.
There's a billion tools for turning source code into executable software (that's "building") and the fact is there's no general recipe that works for every project. When you aren't able to figure out how to do things from available documentation, it's always nice if you can a successful example and reverse engineer it from there. Happily, we can find such an example in this repository. This project has public CI/CD (continuous integration/continuous deployment), i.e., the ability to write recipes ("workflows") for automated building and distribution of the software. In general for projects using CI/CD on GitHub, you can find "workflow" files in the Actions tab of the GitHub repo page, or in the Here comes the reverse-engineering: the workflow we're looking at is ultimately translated to a set of commands run in a Linux environment that you could replicate on your own Linux desktop; however, you can't just copy-paste this workflow file into your terminal. It doesn't hurt to make yourself familiar with the GitHub Action Workflow syntax if you're confused about any of the components of this file. Here we can see some useful elements: the action used to build images is Maybe this is enough to go on? You can try
What I'm about to say is sort-of "cutting a corner" and you should be mindful about not taking people's time for granted (i.e. not spamming), but: there's often nothing wrong with submitting a draft pull-request with your changes before/in-parallel with testing/building the project yourself. The pull-request should not be accepted before you can demonstrate that the project builds, but you can get more direct feedback about the changes this way, and attempt builds as you go. The workflow for doing that usually looks like:
TLDR, since I got a bit carried away: It's cool to learn by picking up good-first-issues, but depending on what you already know/don't know, the learning curve even for simple code changes can be steep! I would strongly recommend, at the same time as working on this issue, finding a good git/GitHub tutorial with examples and following along. https://git-scm.com/docs/user-manual is a great place to start; maybe there is a nice Youtube channel/playlist of someone working alongside the examples for reference. |
wao! Thank you so much @michaelhaaf for this in depth explanation! that is really great 🙏 |
Fixes issue ublue-os#67 This adds an alias for cat to use bat without line numbers or paging so we get the same behaviour as cat with the syntax highlighting from bat.
Fixes issue ublue-os#67 This adds an alias for cat to use bat without line numbers or paging so we get the same behaviour as cat with the syntax highlighting from bat.
Fixes issue ublue-os#67 This adds an alias for cat to use bat without line numbers or paging so we get the same behaviour as cat with the syntax highlighting from bat.
Recommendation via mastodon from dperson. However I'd like to turn off the line numbers so that multi line copy and paste works ootb. It's already in wolfi.
The text was updated successfully, but these errors were encountered: