Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new akmods build process #87

Merged
merged 5 commits into from
May 6, 2023
Merged

Conversation

dhoell
Copy link
Contributor

@dhoell dhoell commented Mar 24, 2023

See my PRs in -config, -akmods, -nvidia.

  • No technical changes required
  • Build time adjusted to be more in line with quay.io/fedora-ostree-desktops, this should fix common occurrences where the fedora repositories have been updated before we build the images, leading to mismatched packages. Build times in other repos have been adjusted accordingly.

cashbobhudson and others added 4 commits March 23, 2023 15:37
change containerfile to refer to my -config, ublue-os-just will automatically be installed by build.sh
- build at 7:00, closer to upstream
@dhoell dhoell requested a review from castrojo as a code owner March 24, 2023 10:53
@dhoell dhoell changed the title Feat: new akmods build process feat: new akmods build process Mar 24, 2023
@@ -7,7 +7,7 @@ on:
- '**.md'
- '**.txt'
schedule:
- cron: '20 20 * * *' # 8:20pm everyday
- cron: '0 7 * * *' # 7 am everyday
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question on this change... this is 7:00am UTC.

I checked the last several days of https://quay.io/repository/fedora-ostree-desktops/silverblue?tab=tags (also looked at base, kinoite, sericea, vauxite) and it seems they are generally done building by 4am UTC...

So it seems this is a good change as it leaves a few hours of buffer for those to complete.

But I wanted to confirm as the original 8:20pm time was also planned to run an hour or so after a daily build. What changed? Was the old time based on the cgwalters images?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was answered in Discord. New time is as I expected. Looks good to me.

@castrojo castrojo enabled auto-merge May 6, 2023 04:11
@castrojo castrojo added this pull request to the merge queue May 6, 2023
Merged via the queue into ublue-os:main with commit f0503ff May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants