Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace gnome-software with non-dkms version on F41 and above. #671

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

KyleGospo
Copy link
Member

@KyleGospo KyleGospo commented Nov 2, 2024

Fedora 47 includes a version of gnome-software with a DKMS plugin compiled in. This plugin tries to aid the user by helping setup a MOK for custom kmods, etc... Since Universal Blue has another solution for this which does not include users self-compiling kmods, we needed to disable this.

See: https://copr.fedorainfracloud.org/coprs/ublue-os/staging/package/gnome-software/

@KyleGospo KyleGospo requested a review from castrojo as a code owner November 2, 2024 18:25
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Nov 2, 2024
install.sh Outdated Show resolved Hide resolved
@KyleGospo KyleGospo marked this pull request as draft November 5, 2024 22:01
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops... i see this doesn't work... we need to figure this out. :-/

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Nov 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 5, 2024
@bsherman bsherman marked this pull request as ready for review November 5, 2024 22:37
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 5, 2024
@KyleGospo KyleGospo enabled auto-merge November 5, 2024 22:38
@KyleGospo KyleGospo added this pull request to the merge queue Nov 5, 2024
@bsherman bsherman removed this pull request from the merge queue due to a manual request Nov 5, 2024
@bsherman
Copy link
Contributor

bsherman commented Nov 5, 2024

Testing a change before we merge this.

@bsherman bsherman merged commit 90054b9 into main Nov 5, 2024
18 checks passed
@bsherman bsherman deleted the gnome-software-dkms branch November 5, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants