Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Override copr plugin config to use fedora chroot by default #663

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix: Override copr plugin config to use fedora chroot by default #663

merged 1 commit into from
Oct 31, 2024

Conversation

Zeglius
Copy link
Contributor

@Zeglius Zeglius commented Oct 31, 2024

This override is to handle the default behavior of dnf5 using ID at /etc/os-release to select which chroot gets used to fetch the copr repo.

An example of the behavior displayed without this override in Bazzite:

sudo dnf5 copr enable msmafra/hyprland
 https://copr.fedorainfracloud.org/api_3/rpmrepo/msmafra/hyprland/bazzite-41/                        100% | 726.0   B/s | 457.0   B |  00m01s
Chroot not found in the given Copr project (bazzite-41-x86_64).                                                                              You can choose one of the available chroots explicitly:
 fedora-40-aarch64
 fedora-40-x86_64
 fedora-41-aarch64
 fedora-41-x86_64
 fedora-rawhide-aarch64
 fedora-rawhide-x86_64

@Zeglius Zeglius requested a review from castrojo as a code owner October 31, 2024 16:41
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Oct 31, 2024
@KyleGospo KyleGospo merged commit 12829ea into ublue-os:main Oct 31, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Merged
@Zeglius Zeglius deleted the override-copr branch October 31, 2024 16:48
Zeglius added a commit to Zeglius/bazzite that referenced this pull request Oct 31, 2024
@Zeglius
feat: Replace copr wrapper with a simpler one
35f7287 
Depends on ublue-os/main#663
Zeglius added a commit to Zeglius/bazzite that referenced this pull request Oct 31, 2024
@Zeglius
chore: Simpler copr script
e10aa5f 
This depends on ublue-os/main#663
@Zeglius Zeglius mentioned this pull request Oct 31, 2024
Merged
bsherman added a commit that referenced this pull request Oct 31, 2024
@bsherman
chore: Revert "fix: Override copr plugin config to use fedora chroot …
d696f72 
…by default (#663)"

This reverts commit 12829ea.

It was accidentally force merged without proper approvals.
@bsherman bsherman mentioned this pull request Oct 31, 2024
Merged
@bsherman
Copy link
Contributor

@Zeglius this PR was accidentally force-merged, thus I've reverted it in #664 .

The fix itself is appreciated, so please re-submit.

I can tell you in advance, the one change I'd request is to use an example COPR repo from the ublue-os org itself rather than a 3rd party.

Thank you.

@Zeglius Zeglius mentioned this pull request Oct 31, 2024
Merged
KyleGospo pushed a commit to ublue-os/bazzite that referenced this pull request Nov 1, 2024
@Zeglius
chore: Simpler copr script (#1829)
0edc615 
This depends on ublue-os/main#663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiftydinar fiftydinar fiftydinar approved these changes

@castrojo castrojo Awaiting requested review from castrojo castrojo is a code owner

Assignees
No one assigned
Labels
bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zeglius @bsherman @fiftydinar @KyleGospo