Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Fedora 38 & kmods images #562

Merged
merged 4 commits into from
Apr 27, 2024
Merged

Conversation

p5
Copy link
Member

@p5 p5 commented Apr 22, 2024

Remove kmods builds
Remove Fedora 38

Do not merge until a few weeks after Fedora 40 dropped

Relates: #527

Remove kmods builds
Bump Fedora 40 to latest
Bump Fedora 39 to stable
IS_LATEST_VERSION=true
IS_STABLE_VERSION=true
IS_GTS_VERSION=false
elif [[ "${{ matrix.fedora_version }}" -eq "40" ]]; then
elif [[ "${{ matrix.fedora_version }}" -eq "41" ]]; then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we don't really need this, but no point ripping this out when it'll be added in 4 months again.

@p5 p5 requested a review from bsherman April 22, 2024 18:54
@storopoli
Copy link

Is this for the Fedora 40 release?
Then latest will de F40 and gts F39?

@p5 p5 changed the title feat: bump Fedora 40 to latest, Fedora 39 to stable and deprecate Fedora 38 feat: bump Fedora 40 to latest, Fedora 39 to stable and deprecate Fedora 38 & kmods Apr 22, 2024
@bsherman
Copy link
Contributor

@p5 I don't think we should tie the release/promotion of F40 to stable/latest to removing F38 builds. Shouldn't removing F38 be a distinct act?

As much as I want to stop maintaining 38, I really am hesitant to drop those builds this week... feels like we should get a bit closer to upstream's EOL first.

@bsherman
Copy link
Contributor

latest will be F40 and gts F39?

yes

@p5
Copy link
Member Author

p5 commented Apr 22, 2024

@p5 I don't think we should tie the release/promotion of F40 to stable/latest to removing F38 builds. Shouldn't removing F38 be a distinct act?

As much as I want to stop maintaining 38, I really am hesitant to drop those builds this week... feels like we should get a bit closer to upstream's EOL first.

Understood. I thought Fedora maintained two releases at once, therefore F38 will be EOL'd tomorrow, but it must be three versions at once.

So including only the Containerfile ARG defaults

ARG FEDORA_MAJOR_VERSION="${FEDORA_MAJOR_VERSION:-40}"

FROM ${BASE_IMAGE}:${FEDORA_MAJOR_VERSION}

ARG IMAGE_NAME="${IMAGE_NAME:-silverblue}"
ARG FEDORA_MAJOR_VERSION="${FEDORA_MAJOR_VERSION:-40}"

and

          if [[ "${{ matrix.fedora_version }}" -eq "39" ]]; then
            IS_LATEST_VERSION=false
            IS_STABLE_VERSION=true
            IS_GTS_VERSION=true
          elif [[ "${{ matrix.fedora_version }}" -eq "40" ]]; then
            IS_LATEST_VERSION=true
            IS_STABLE_VERSION=true
            IS_GTS_VERSION=false
          elif [[ "${{ matrix.fedora_version }}" -eq "41" ]]; then

is enough for tomorrow?

@bsherman
Copy link
Contributor

Understood. I thought Fedora maintained two releases at once, therefore F38 will be EOL'd tomorrow, but it must be three versions at once.

Yeah, there's usually around a month of overlap.

So including only the Containerfile ARG defaults

[... snip ...]

is enough for tomorrow?

Yes, but I want to review the final PR again, i think maybe some copy paste issues in the comment above.

@p5 p5 changed the title feat: bump Fedora 40 to latest, Fedora 39 to stable and deprecate Fedora 38 & kmods chore: deprecate Fedora 38 & kmods Apr 22, 2024
@p5
Copy link
Member Author

p5 commented Apr 22, 2024

Have repurposed this PR to only deprecate Fedora 38 and kmod builds. Will bump Fedora 39 and 40 in this PR

@bsherman
Copy link
Contributor

@p5 I would suggest that "deprecate" means "not recommended for use" but this PR will remove 38 so it cannot be used.

@p5 p5 changed the title chore: deprecate Fedora 38 & kmods chore: remove Fedora 38 & kmods images Apr 22, 2024
Copy link
Contributor

@dylanmtaylor dylanmtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should delete lxqt from the image_name list.

@p5
Copy link
Member Author

p5 commented Apr 25, 2024

You should delete lxqt from the image_name list.

Good catch
Done in 9508130

@p5 p5 marked this pull request as ready for review April 27, 2024 06:56
@p5 p5 requested a review from castrojo as a code owner April 27, 2024 06:56
@bsherman
Copy link
Contributor

Remove kmods builds Remove Fedora 38

Do not merge until a few weeks after Fedora 40 dropped

Regarding the "when" of removing Fedora 38... we recently updated our governance document to make this more clear:

Our goal is to build two currently supported versions of Fedora, the most recent and one previous version.

https://universal-blue.discourse.group/docs?topic=51

Given this update, we should be good to remove immediately.

@bsherman bsherman enabled auto-merge April 27, 2024 07:05
@bsherman bsherman added this pull request to the merge queue Apr 27, 2024
Merged via the queue into main with commit 2d90d1e Apr 27, 2024
18 checks passed
@bsherman bsherman deleted the bump-fedora-40-to-latest branch April 27, 2024 07:13
jenalj pushed a commit to jenalj/ublue-main that referenced this pull request May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants