-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove Fedora 38 & kmods images #562
Conversation
Remove kmods builds Bump Fedora 40 to latest Bump Fedora 39 to stable
.github/workflows/reusable-build.yml
Outdated
IS_LATEST_VERSION=true | ||
IS_STABLE_VERSION=true | ||
IS_GTS_VERSION=false | ||
elif [[ "${{ matrix.fedora_version }}" -eq "40" ]]; then | ||
elif [[ "${{ matrix.fedora_version }}" -eq "41" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we don't really need this, but no point ripping this out when it'll be added in 4 months again.
Is this for the Fedora 40 release? |
@p5 I don't think we should tie the release/promotion of F40 to stable/latest to removing F38 builds. Shouldn't removing F38 be a distinct act? As much as I want to stop maintaining 38, I really am hesitant to drop those builds this week... feels like we should get a bit closer to upstream's EOL first. |
yes |
Understood. I thought Fedora maintained two releases at once, therefore F38 will be EOL'd tomorrow, but it must be three versions at once. So including only the Containerfile ARG defaults
and
is enough for tomorrow? |
Yeah, there's usually around a month of overlap.
Yes, but I want to review the final PR again, i think maybe some copy paste issues in the comment above. |
Have repurposed this PR to only deprecate Fedora 38 and kmod builds. Will bump Fedora 39 and 40 in this PR |
@p5 I would suggest that "deprecate" means "not recommended for use" but this PR will remove 38 so it cannot be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should delete lxqt from the image_name list.
Good catch |
Regarding the "when" of removing Fedora 38... we recently updated our governance document to make this more clear:
https://universal-blue.discourse.group/docs?topic=51 Given this update, we should be good to remove immediately. |
Remove kmods builds
Remove Fedora 38
Do not merge until a few weeks after Fedora 40 dropped
Relates: #527