chore: alternatives workaround refactor #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've tried to keep the boilerplate of image building in the Containerfile, while the content and details specific to the image being built is in scripts: - install.sh - packages.sh - post-install.sh This refactor moves some commands to the scripts which had instead been added to Containerfile.
This creates /var/lib/alternatives so that any RPM which has a post-install script referencing 'alternatives' will not fail due to its absense. In addition, this goes the extra mile by copying the contents of /var/lib/alternatives into the resulting image, which preserves the altenratives database for any installed packages. This second part could be controversial as there is an expectation that there's minimal (or no) contents left in /var after running 'ostree container commit', but it does work and is useful.
castrojo
approved these changes
Mar 26, 2024
p5
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates /var/lib/alternatives so that any RPM which has a
post-install script referencing 'alternatives' will not fail due to its
absense.
In addition, this goes the extra mile by copying the contents of
/var/lib/alternatives into the resulting image, which preserves the
alternatives database for any installed packages.
This second part could be controversial as there is an expectation that
there's minimal (or no) contents left in /var after running
'ostree container commit', but it does work and is useful.
If we agree to merge this, I'll also be including it in the HWE images (nvidia, asus*, surface*, etc) and it can be used to replace other workarounds like manually symlinking
ldin bluefin/bazzite/etc.This is a general form of a workaround for problems like: ublue-os/hwe#188