Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase onto quay.io/fedora images #78

Closed
castrojo opened this issue Mar 16, 2023 · 20 comments
Closed

Rebase onto quay.io/fedora images #78

castrojo opened this issue Mar 16, 2023 · 20 comments
Milestone
F39

Comments

@castrojo
Copy link
Member

We've been using the images at: quay.io/fedora-ostree-desktops/
The new location is: quay.io/fedora/fedora-silverblue (as an example)

This issue is to track that change.

See also https://pagure.io/releng/issue/11047#comment-846909
@castrojo castrojo added this to the 1.0 milestone Mar 16, 2023
@castrojo
Copy link
Member Author

castrojo commented Apr 9, 2023

This won't be for 1.0, the quay.io/fedora namespace is only doing 39 and rawhide so it's unlikely they'll backfill that, so we'll revisit for F39.

@castrojo castrojo moved this to Blocked/Needs Revisiting in Project Goals Apr 9, 2023
@castrojo
Copy link
Member Author

castrojo commented May 4, 2023

Just realized that the quay.io/fedora images will be 39 only and probably only official images, so we'd probably prefer quay.io/fedora images for everything they provide, but fall back to quay.io/silverblue-desktops to backfill the catalog with other desktops.

@john-ghatas
Copy link
Contributor

john-ghatas commented May 5, 2023 •
edited
Loading

What does using images from quay.io/silverblue-desktops mean concretely? Updates that are a day ish behind for example?

@castrojo
Copy link
Member Author

castrojo commented May 9, 2023

quay.io/silverblue-desktops are unofficial images, Fedora is in the process of making official images but they will live in quay.io/fedora. So at some point we'll switch to those images when Fedora says they're ready. For now we're assuming that they're still going to remain being daily builds.

@bsherman
Copy link
Contributor

bsherman commented May 9, 2023

Also, maybe the question relates to use of quay.io/fedora-ostree-desktops vs quay.io/silverblue-desktops ?

I don't know that quay.io/silverblue-desktops exists (if so, please show me what I'm missing), because we are currently using quay.io/fedora-ostree-desktops and I think maybe you just wrote the former by accident?

@castrojo
Copy link
Member Author

castrojo commented May 9, 2023

Ooops yea, pre-caffeinated comment, I meant quay.io/fedora-ostree-desktops

@castrojo castrojo mentioned this issue May 12, 2023
Closed
@castrojo castrojo modified the milestones: Beta, F39 May 15, 2023
@castrojo castrojo moved this from Blocked/Needs Revisiting to Todo in Project Goals Jul 29, 2023
@castrojo castrojo moved this from Todo to Blocked/Needs Revisiting in Project Goals Aug 25, 2023
@castrojo
Copy link
Member Author

Fedora has official container builds now for some of them here:

https://quay.io/organization/fedora

We need to special case slurping in silverblue,kinoite,and sericea

@bsherman bsherman assigned bsherman and unassigned bsherman Sep 22, 2023
@bsherman
Copy link
Contributor

I was eager to do this, but I want to hold off for a bit... the recent big changes to organization and the in-flight F39 stuff seems like a bad time to introduce more complexity. I'd like to see some stability before adding this change.

@castrojo castrojo mentioned this issue Sep 24, 2023
Closed
@castrojo
Copy link
Member Author

castrojo commented Nov 8, 2023

Timothee recommended to wait to switch, so we're holding off still.

@noelmiller
Copy link
Member

noelmiller commented Jan 24, 2024 •
edited
Loading

I would like to reopen this for discussion. There are official images available for Silverblue and Kinoite.

Are there any technical barriers to us moving to using the official images for our Silverblue and Kinoite based variants?

@bsherman
Copy link
Contributor

I would like to reopen this for discussion. There are official images available for Silverblue and Kinoite.

I don't think these images are any more official today as they were when I implemented the PR for it in #363 ... and then Timothee suggested holding off... so we backed away... as he is the one maintaining our current upstream at https://quay.io/repository/fedora-ostree-desktops/ I not too eager to switch until he thinks it good.

Are there any technical barriers to us moving to using the official images for our Silverblue and Kinoite based variants?

As I mentioned, I've already implemented this once. The only real technical issue is the "official" images are currently only Silverblue/Kinoite, not any of the other upstream spins (Sericea, Onyx, etc), and certainly not an upstream base image.

So it's doable, but a minor headache as some of our images would be "more official" than others due to a different upstream source.

@noelmiller
Copy link
Member

I don't think these images are any more official today as they were when I implemented the PR for it in #363 ... and then Timothee suggested holding off... so we backed away... as he is the one maintaining our current upstream at https://quay.io/repository/fedora-ostree-desktops/ I not too eager to switch until he thinks it good.

I 100% agree and I would even debate not switching to the "official images" until F40 so we aren't switching mid-release.

As I mentioned, I've already implemented this once. The only real technical issue is the "official" images are currently only Silverblue/Kinoite, not any of the other upstream spins (Sericea, Onyx, etc), and certainly not an upstream base image.

So it's doable, but a minor headache as some of our images would be "more official" than others due to a different upstream source.

Yeah, that would be a headache.

What might be valuable is if we can get a better understanding on where the initiative is at from Fedora themselves. I'm curious who is responsible for the Atomic Desktops in general at the project and where we can look to get updates on Atomic Desktop related things. I do know the Fedora Discourse and Matrix exists (I'm just not sure who monitors those channels). There is also an issue tracker

It would be helpful if they had like a project board or something to view so we can get a better idea of where their priorities are. Or even a conversation with a Project PM for Atomic Desktops would be helpful too!

Just some thoughts I had.

@travier
Copy link

travier commented Jan 24, 2024 •
edited
Loading

This is our main issue tracker for Atomic desktops: https://gitlab.com/fedora/ostree/sig/-/issues

For this issue (https://gitlab.com/fedora/ostree/sig/-/issues/2), we now produce the images (ociarchives) but we still need to sync them to quay.io. Once we have that, Ublue can start using them.

Fedora only produces Silverblue, Kinoite, Sericea & Onyx right now so the other images will likely have to stay on the experimental ones for now. I can keep building a subset of the images until they're made official in Fedora.

johnr14 added a commit to johnr14/ublue-kde-workstation that referenced this issue Mar 15, 2024
@johnr14
Update recipe.yml
13fe343 
change base image 
ublue-os/main#78
@bsherman bsherman moved this from Blocked/Needs Revisiting to Todo in Project Goals Mar 25, 2024
@bsherman bsherman mentioned this issue Mar 24, 2024
Closed
15 tasks
@castrojo castrojo moved this from Todo to Blocked/Needs Revisiting in Project Goals Apr 21, 2024
@castrojo
Copy link
Member Author

We're just going to stick to fedora-ostree-desktops and encourage people to work out of that repo.

@github-project-automation github-project-automation bot moved this from Blocked/Needs Revisiting to Done in Project Goals Apr 21, 2024
@bsherman
Copy link
Contributor

bsherman commented Apr 21, 2024 •
edited
Loading

@castrojo by closing this do you mean this will never be a goal to use Fedora upstream, or not for F40, or not for at least a few releases?

The answer matters to me because if we don't even have this goal anymore I'll rip out some code which has been staged for the switch.

But if just a short term delay, I'd say keep it open and push it back for a future release.

@castrojo
Copy link
Member Author

I'd love to say short term but it's been three cycles, dunno man, up to you. I'm totally ok with a "never unless things get better" if you are lol.

@bsherman
Copy link
Contributor

Fine with me, I just wanted to make sure I'm tracking with you.

If we are thinking long term, I'll cleanup that extra build code because it's annoying to maintain.

bsherman added a commit to ublue-os/akmods that referenced this issue Apr 21, 2024
@bsherman
chore(ci): drop conditional source logic
47ab583 
Since we don't know when, if ever, the fedora org on quay.io will have
reliable images, stop maintaining a conditional which doesn't get used
and makes the workflow more complicated.

Relates: ublue-os/main#78
bsherman added a commit that referenced this issue Apr 21, 2024
@bsherman
chore(ci): drop conditional source logic
91700d2 
Since we don't know when, if ever, the fedora org on quay.io will have
reliable images, stop maintaining a conditional which doesn't get used
and makes the workflow more complicated.

Relates: #78
This was referenced Apr 21, 2024
Merged
Merged
@travier
Copy link

travier commented Apr 23, 2024

I would say: don't ditch the code! We're getting really close :)

@castrojo
Copy link
Member Author

Al this rate we're never going to go on vacation lol.

@bsherman
Copy link
Contributor

I would say: don't ditch the code! We're getting really close :)

:) it's always in the git history and it's not complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Project Goals
Status: Done
Milestone
F39
Development

When branches are created from issues, their pull requests are automatically linked.

78-rebase-onto-quayiofedora-images ublue-os/main
5 participants
@bsherman @castrojo @noelmiller @john-ghatas @travier