-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: reduce the scope of ublue-os/main images #369
Comments
/vote |
Vote created@bsherman has called for a vote on The members of the following teams have binding votes:
Non-binding votes are also appreciated as a sign of support! How to voteYou can cast your vote by reacting to
Please note that voting for multiple options is not allowed and those votes won't be counted. The vote will be open for |
FYI @ublue-os/approver @EyeCantCU discussed and realized we did not specify timeline in this proposal. As such, I've added a timeline section clarifying this change will be for Fedora 39 forward. We'll maintain existing setup for Fedora 37 and 38. |
Vote closedThe vote passed! 🎉
Summary
Binding votes (5)
|
User | Vote | Timestamp |
---|---|---|
@fiftydinar | In favor | 2023-09-25 19:20:14.0 +00:00:00 |
@xynydev | Abstain | 2023-09-25 19:26:11.0 +00:00:00 |
@Zoialord | In favor | 2023-09-25 21:19:09.0 +00:00:00 |
@castrojo | In favor | 2023-09-25 21:21:23.0 +00:00:00 |
@Daredevil3869 | In favor | 2023-09-25 23:21:48.0 +00:00:00 |
@nicknamenamenick | In favor | 2023-09-26 1:25:25.0 +00:00:00 |
@ArtikusHG | In favor | 2023-09-26 6:14:55.0 +00:00:00 |
@MickSt | In favor | 2023-09-28 13:19:45.0 +00:00:00 |
Just to account for the bot missing this, I initially +0'ed and then changed it to +1 so that might be why I'm non-binding. So just leaving a comment for the record. |
@EyeCantCU and I will tag team on the implementation for this. I'd like to have a number of PR's staged so we can roll out cleanly. |
Sounds great! Happy to get to work on this |
Another edit: I discovered that |
With the merging of #375 (and #390) ... the bulk of the work for this proposal has been completed.
|
Website was also updated to add info about this to the |
And... ASUS has had an update for this: ublue-os/asus#14 |
Anything left to do or can we close this out? |
@EyeCantCU I think the last things related to this were Asus and Surface builds, which you got wrapped up, right? |
Ok @EyeCantCU says this is all done, what's the next step? |
I believe this is all wrapped up :) |
I'm closing it. :-) |
Summary
Revise scope of Universal Blue Main Images such that kmods (and associated kernel packages) are no longer included.
Description
The purpose of this change is to streamline build processes(current and future), maximize use of
*-main
images as a foundation for downstream efforts, and enable maximal flexibility for users running these images.The primary change removes the following packages from
*-main
images:Scope of Changes
*-main
builds*-nokmods
as those images will be identical to*-main
after this change*-main
*-main
images should not include kmods, kernel-devel, kernel-tools packages*-main
may be used directly but is primarily a foundational part of the Universal Blue toolkit.akmods
.Not in scope
*-nvidia
images: they MUST have the nvidia kmod, so that will stay (still based on*-main
so will lose the other kmods)Benefits to Universal Blue
*-main
cannot be removed downstream or on a running system which prevents use as a base for images like asus/surface, any changes to kernel, as well as layering of related packages on running systems)Feedback
A conversation in discord was had about narrowing the scope of our
*-main
images such that they no longer include kmods.There were questions about impact to users of existing
*-main
images, the primary concern being removal ofxpadneo
andv4l2loopback
as they are the two kmods which have existed for a longer time.It was suggested we suggest users use
*-nokmods
images if they have issues with kmods in*-main
, but that does not address the desire to simplify build processes within the Universal Blue organization.Ways to address
We can suggest use of bazzite, bazzite-gnome or bluefin for users not wishing to build a custom image.
In the future, to partially offset the impact of these changes,
just
scripts may be implemented that simplify the installation of the kmods Universal Blue provides.Timeline
To minimize the impact on current users of our
*-main
images, these changes will go into effect with Fedora 39. Fedora 37 and 38 will continue to provide the*-nokmods
images until their EOL in November and next May. Starting with Fedora 39,*-main
images would exclude all kmods, focusing only on refinements to the base images.Other Thoughts
Hardware enablement has long been included in the scope of main images, but it was initially focused on the addition of udev rules, not the addition of kmods; those came later.
As of this writing, we have recently created
*-nokmods
because*-main
's inclusion of a few kmods prevented it from being used as an upstream foundation for some downstreams needing a kernel swap, specifically*-asus
and*-surface
images.Additionally, we recently discovered that that this longstanding bug was actually caused by the installation of kmods(and/or kernel-devel packages) in
*-main
images themselves.These recent changes/discoveries and the increasing burden of managing image hierarchy are the primary motivators for narrowing the focus and "ripping the band-aid off" now, before things have a chance to become more complex.
Addendum
Impact of removing the kmods from main would be:
Impact of not doing this change is that:
Above from @akdev1l : https://github.com/orgs/ublue-os/discussions/224#discussioncomment-7104856
Authors
Edits:
The text was updated successfully, but these errors were encountered: