feat: kernel signing cache kernels #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsherman
requested changes
Jul 11, 2024
p5
reviewed
Jul 11, 2024
| @@ -166,6 +166,21 @@ jobs: | |||
| io.artifacthub.package.readme-url=https://raw.githubusercontent.com/${{ github.repository }}/main/README.md | |||
| io.artifacthub.package.logo-url=https://avatars.githubusercontent.com/u/1728152?s=200&v=4 | |||
|
|
|||
| - name: Retrieve Signing Key | |||
| if: (github.event_name == 'scheduled' || github.event_name == 'workflow_dispatch' || github.event_name == 'merge_group') && github.event_name != 'pull_request' | |||
There was a problem hiding this comment.
Don't think about it now, but it might be worth having a sample signing key that runs on PRs to make it easier to debug in future
There was a problem hiding this comment.
Oh, we have signing keys added in this PR anyway. Any reason not to (at a later date) use the .test keys in this step during pull requests?
There was a problem hiding this comment.
We do, you can see in fetch.sh if the private-key is 0 bytes, we copy the test keys over.
There was a problem hiding this comment.
Ohhh, sorry. We don't need to retrieve them since they are already in the repo 🤦
m2Giles
commented
Jul 11, 2024
| fi | ||
|
|
||
| if [[ "${kernel_flavor}" =~ fsync ]]; then | ||
| dnf download -y \ | ||
| kernel-headers-"${kernel_version}" | ||
| fi | ||
|
|
||
| if [[ ! -s /tmp/certs/private_key.priv ]]; then |
There was a problem hiding this comment.
@p5 Here is the logic for signing during PRs.
bsherman
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to implement the workflow changes for copying in actual key.
Thank you for contributing to the Universal Blue project!
Please read the Contributor's Guide before submitting a pull request.