feat: add kernel-bazzite to cache #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleGospo
previously approved these changes
Oct 13, 2024
p5
reviewed
Oct 18, 2024
|
really did not like that json passthrough. Switched to a tag and hardcoded the links |
Only concern with this method is that you added a build argument and its going to fail builds. And it failed builds. |
|
Should be optional and empty if unset, let me fix it. |
|
It was missing just from Containerfile and Kernel-Core was also missing. Should be fine now. |
m2Giles
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early draft PR for adding kernel-bazzite to kernel-cache. Waiting for Kyle to comment for it. Kind of untested.