This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
fix: make loop device during container build of ISO #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates the loop device during container runtime which allows lorax to build the ISO and not need to rely on a host provided device file. Fixes: #22
bsherman
requested review from
HikariKnight,
noelmiller,
bigpod98,
KyleGospo and
p5
|
So I confirmed that running podman as sudo allows the ISO to get created. Tested this locally. Could you update this PR with documentation regarding podman: NOTE: nevermind, I can just do it. |
noelmiller
approved these changes
Feb 27, 2024
castrojo
approved these changes
Feb 27, 2024
|
Fixes: #36 as well |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates the loop device during container runtime which allows lorax to build the ISO and not need to rely on a host provided device file.
Fixes: #22