Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: build initramfs for surface, asus and nvidia #258

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Conversation

m2Giles
Copy link
Member

@m2Giles m2Giles commented Jun 28, 2024

Fixes: #250

KyleGospo
KyleGospo previously approved these changes Jun 28, 2024
castrojo
castrojo previously approved these changes Jun 28, 2024
bsherman
bsherman previously approved these changes Jun 28, 2024
@bsherman
Copy link
Contributor

The merge check is auto-building against the wrong branch, thus the failures, but this is clean and should get merged. I support merging without requirements if @m2Giles wants to proceed that way.

@m2Giles m2Giles enabled auto-merge June 28, 2024 19:23
@m2Giles
Copy link
Member Author

m2Giles commented Jun 28, 2024

It seems that PRs don't get picked up quickly for synchronization action run.

That said. Failures are due to kernel skew in Asus 40 and lazurite having a failed build.

Others are spurious. I see green for stuff. @bsherman let's get this merged

@m2Giles m2Giles dismissed stale reviews from KyleGospo, castrojo, and bsherman via 1d62b5e June 28, 2024 21:03
@bsherman
Copy link
Contributor

That said. Failures are due to kernel skew in Asus 40 and lazurite having a failed build.

Others are spurious. I see green for stuff. @bsherman let's get this merged

Yes, this looks good on all primary builds (asus-nvidia and lazurite aside). Let's merge this.

@bsherman bsherman disabled auto-merge June 28, 2024 21:14
@bsherman bsherman merged commit 1b2c042 into main Jun 28, 2024
75 of 87 checks passed
@bsherman bsherman deleted the initramfs branch June 28, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface: Include kernel modules into initramfs in build-time, instead of utilizing initramfs-etc
4 participants