Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix possible empty version meta on image #878

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

bsherman
Copy link
Contributor

@bsherman bsherman commented Feb 7, 2024

This ensures that when inspecting upstream image, if an error occurs, or the resulting value is empty or 'null', we fail our build instead of propegating a bogus version downstream.

Closes: ublue-os/main#487

This ensures that when inspecting upstream image, if an error occurs, or
the resulting value is empty or 'null', we fail our build instead of
propegating a bogus version downstream.

Relates: ublue-os/main#487
@bsherman bsherman requested a review from castrojo as a code owner February 7, 2024 03:57
@bsherman bsherman enabled auto-merge February 7, 2024 04:02
@castrojo castrojo disabled auto-merge February 7, 2024 15:27
@castrojo castrojo merged commit e801dfb into main Feb 7, 2024
23 of 30 checks passed
@castrojo castrojo deleted the better-version-check branch February 7, 2024 15:27
bayou-brogrammer pushed a commit to bayou-brogrammer/bluefin that referenced this pull request Feb 11, 2024
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Get current version" step fails silently for internal failures instead of failing the build
2 participants