Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Verify remaining toolboxes #779

Merged
merged 2 commits into from
Jan 3, 2024
Merged

feat(ci): Verify remaining toolboxes #779

merged 2 commits into from
Jan 3, 2024

Conversation

EyeCantCU
Copy link
Member

Verifies the Ubuntu toolbox as well as the Fedora distrobox before building them.

All containers used in Bluefin are now verified!

@EyeCantCU EyeCantCU requested a review from castrojo as a code owner January 3, 2024 12:08
Copy link
Member

@castrojo castrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you!

@castrojo castrojo enabled auto-merge January 3, 2024 12:13
Comment on lines 81 to 82
extra-args: |
--disable-content-trust
Copy link
Member

@p5 p5 Jan 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we have this here still? I don't believe it's required and provides even more security for in-transit communication

Content trust gives you the ability to verify both the integrity and the publisher of all the data received from a registry over any channel.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I had to guess, this is because it would require us to trust the container locally before pushing it to the registry. In Red Hat's own workflows, for push-to-registry, they disable content trust:

https://github.com/search?q=repo%3Aredhat-actions%2Fpush-to-registry%20--disable-content-trust&type=code

However, I do believe this is something that would be worth looking into. At the very least, we may be able to emulate this behavior by signing the container locally with cosign before a push, and then verifying it after

Copy link
Member

@p5 p5 Jan 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to remove the flag if nobody remembers why it's there.
It works without it in my older workflow that use these actions. Have made a PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great!

@castrojo castrojo added this pull request to the merge queue Jan 3, 2024
Merged via the queue into main with commit bf5868a Jan 3, 2024
34 checks passed
@castrojo castrojo deleted the verify-toolboxes branch January 3, 2024 12:43
wizzywizard65 pushed a commit to wizzywizard65/bluefin that referenced this pull request Jan 3, 2024
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants