Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dx): turn on docker socket by default #740

Merged
merged 4 commits into from
Dec 20, 2023
Merged

feat(dx): turn on docker socket by default #740

merged 4 commits into from
Dec 20, 2023

Conversation

castrojo
Copy link
Member

And add the user to the docker group

And add the user to the docker group
Containerfile Outdated Show resolved Hide resolved
Co-authored-by: Robert Sturla <[email protected]>
p5
p5 previously approved these changes Dec 20, 2023
Copy link
Member

@p5 p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not certain we can add users to groups this way, but let's give it a go

I guess we found out this doesn't work in the containerfile. 😄
@castrojo castrojo enabled auto-merge December 20, 2023 20:11
@castrojo castrojo added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit ac2027c Dec 20, 2023
34 checks passed
@castrojo castrojo deleted the castrojo-patch-6 branch December 20, 2023 20:56
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants