Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Prompt integration #728

Merged
merged 6 commits into from
Dec 17, 2023
Merged

feat: Add Prompt integration #728

merged 6 commits into from
Dec 17, 2023

Conversation

KyleGospo
Copy link
Member

@KyleGospo KyleGospo commented Dec 13, 2023

Adds Prompt Integration via nautilus-open-any-terminal, and xdg-terminal-exec.

@KyleGospo KyleGospo force-pushed the prompt branch 5 times, most recently from 75d2258 to ff3c8a2 Compare December 13, 2023 20:35
Copy link
Contributor

@bobslept bobslept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I see the fedora shortcut is still pointing to blackbox, I will push a commit for that one.

Added a small question about compatibility of the new added extension, with the gnome 44 and 45 breaking changes we probably need a bit carefull with that.

Great work!

@castrojo
Copy link
Member

I noticed that prompt will not start a container on a fresh boot, so opening it leads to an error. Whose responsibility is it to ensure the container starts, the system or the terminal?

If it's our responsibility then I think we'll need the podman autostart service and I think we can add autostart labels but we should discuss the implications of that.

@KyleGospo
Copy link
Member Author

@castrojo Do we want to install Prompt as a system flatpak or keep it a user flatpak like the others? I think system makes more sense given the deep integration

@castrojo
Copy link
Member

I don't have a strong opinion, whatever we think is best? Let's see what others say.

@fiftydinar
Copy link
Collaborator

System makes more sense imo.

@KyleGospo KyleGospo marked this pull request as ready for review December 14, 2023 23:45
@KyleGospo KyleGospo requested a review from castrojo as a code owner December 14, 2023 23:45
p5
p5 previously approved these changes Dec 15, 2023
Copy link
Member

@p5 p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would prefer waiting for someone who knows more about this flatpak than I do.

Copy link
Contributor

@bobslept bobslept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small missing character I think it looks good!

bobslept
bobslept previously approved these changes Dec 15, 2023
@KyleGospo
Copy link
Member Author

KyleGospo commented Dec 15, 2023

If we don't want to wait on some of these improvements the dconf changes and Prompt install line can be split into their own PR, the rest of this will work today.

Which is to say the logo menu and customizable terminal launcher for Nautilus. Could even be pointed to Blackbox but it defaults to gnome terminal.

@castrojo
Copy link
Member

Sgtm, that way we can get one done and out of the way!

@KyleGospo KyleGospo force-pushed the prompt branch 3 times, most recently from eb2e3ae to 44bbb3e Compare December 15, 2023 02:28
@KyleGospo KyleGospo changed the title feat: Add Prompt integration & Logo Menu feat: Add Prompt integration Dec 15, 2023
@KyleGospo KyleGospo marked this pull request as draft December 15, 2023 02:29
@KyleGospo
Copy link
Member Author

That's broken up now, see #732 for the ready-to-merge parts of this.

@KyleGospo KyleGospo force-pushed the prompt branch 2 times, most recently from 232a682 to ea325c9 Compare December 15, 2023 09:06
@castrojo
Copy link
Member

I noticed in bazzite that you put it on the dock, can you put it on the dock in -dx only? we have a dir for dx dconf that should do the trick!

@KyleGospo
Copy link
Member Author

Yep can do, did you want layered prompt as well or did you want to wait for the flatpak?

@KyleGospo KyleGospo marked this pull request as ready for review December 16, 2023 22:15
@KyleGospo
Copy link
Member Author

Let's let it shake out for a few days in bazzite then we'll do it!

Re-based and added requested changes

@castrojo castrojo enabled auto-merge December 16, 2023 23:55
castrojo
castrojo previously approved these changes Dec 16, 2023
Copy link
Member

@castrojo castrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nm, let's do this.

image

@castrojo castrojo added this pull request to the merge queue Dec 16, 2023
@KyleGospo KyleGospo removed this pull request from the merge queue due to a manual request Dec 17, 2023
@KyleGospo
Copy link
Member Author

KyleGospo commented Dec 17, 2023

@castrojo abort, need to version gate the dconf changes since Prompt won't install on F38

Fixes 38 and 39 using different default terminals
@KyleGospo KyleGospo enabled auto-merge December 17, 2023 01:17
@KyleGospo KyleGospo disabled auto-merge December 17, 2023 01:17
@KyleGospo KyleGospo enabled auto-merge December 17, 2023 01:17
@KyleGospo
Copy link
Member Author

KyleGospo commented Dec 17, 2023

@castrojo Fixed by only installing the Nautilus extension on 39 and pointing Logomenu to xdg-terminal-exec which is smart enough to pick the best available terminal.

@KyleGospo KyleGospo disabled auto-merge December 17, 2023 01:18
@KyleGospo KyleGospo enabled auto-merge December 17, 2023 01:18
@KyleGospo KyleGospo added this pull request to the merge queue Dec 17, 2023
Merged via the queue into main with commit a03332d Dec 17, 2023
@KyleGospo KyleGospo deleted the prompt branch December 17, 2023 01:49
wizzywizard65 pushed a commit to wizzywizard65/bluefin that referenced this pull request Dec 17, 2023
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants