-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Prompt integration #728
Conversation
75d2258
to
ff3c8a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I see the fedora shortcut is still pointing to blackbox, I will push a commit for that one.
Added a small question about compatibility of the new added extension, with the gnome 44 and 45 breaking changes we probably need a bit carefull with that.
Great work!
I noticed that prompt will not start a container on a fresh boot, so opening it leads to an error. Whose responsibility is it to ensure the container starts, the system or the terminal? If it's our responsibility then I think we'll need the podman autostart service and I think we can add autostart labels but we should discuss the implications of that. |
@castrojo Do we want to install Prompt as a system flatpak or keep it a user flatpak like the others? I think system makes more sense given the deep integration |
I don't have a strong opinion, whatever we think is best? Let's see what others say. |
System makes more sense imo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would prefer waiting for someone who knows more about this flatpak than I do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a small missing character I think it looks good!
If we don't want to wait on some of these improvements the dconf changes and Prompt install line can be split into their own PR, the rest of this will work today. Which is to say the logo menu and customizable terminal launcher for Nautilus. Could even be pointed to Blackbox but it defaults to gnome terminal. |
Sgtm, that way we can get one done and out of the way! |
eb2e3ae
to
44bbb3e
Compare
That's broken up now, see #732 for the ready-to-merge parts of this. |
232a682
to
ea325c9
Compare
I noticed in bazzite that you put it on the dock, can you put it on the dock in -dx only? we have a dir for dx dconf that should do the trick! |
Yep can do, did you want layered prompt as well or did you want to wait for the flatpak? |
chore: Remove Blackbox
Re-based and added requested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@castrojo abort, need to version gate the dconf changes since Prompt won't install on F38 |
Fixes 38 and 39 using different default terminals
@castrojo Fixed by only installing the Nautilus extension on 39 and pointing Logomenu to xdg-terminal-exec which is smart enough to pick the best available terminal. |
Adds Prompt Integration via nautilus-open-any-terminal, and xdg-terminal-exec.