Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: send notification on flatpak installation" #552

Closed
wants to merge 1 commit into from
Closed

Revert "fix: send notification on flatpak installation" #552

wants to merge 1 commit into from

Conversation

bobslept
Copy link
Contributor

@bobslept bobslept commented Oct 1, 2023

Reverts #551

Well too bad this didn't work

@bobslept bobslept requested a review from castrojo as a code owner October 1, 2023 21:48
@bobslept
Copy link
Contributor Author

bobslept commented Oct 2, 2023 •
edited
Loading

I'm not sure if we should revert. Somehow I did see the finished flatpak installation notification today. So it's not totally functional but it seem to do something. I have no clue why I don't see the start notification, but do see the finish one.

@castrojo
Copy link
Member

castrojo commented Oct 2, 2023

Works in a VM, let's keep it!

@castrojo castrojo closed this Oct 2, 2023
@bobslept bobslept deleted the revert-551-fix-flatpak-install-notify branch October 2, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@castrojo castrojo Awaiting requested review from castrojo castrojo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobslept @castrojo