fix: ujust changelog shows stable channel even when on GTS #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
|
Tested this out on a |
|
That's correct. I should have commented on that. There are no release tags for latest and daily images. The previous "latest" was pointing to the latest stable. Hence, if you are on a latest channel, then it was showing you a irrelevant changelog. Now it is failing. A solution is to tag those images. |
|
Maybe we should make the error prettier? |
|
Honestly think the easiest is to fallback to the previous changelogs. We can't readily bake the changelogs into the image and the script takes a bit of time to run. So just fallback to the other changelogs. |
mheuvel-dev
added a commit
to mheuvel-dev/bluefin
that referenced
this pull request
Mar 2, 2025
Fetching changelogs for various release channels from github is impossible and cannot be baked into the image ublue-os#2223.
mheuvel-dev
force-pushed
the
fix-changelog-url
branch
from
d36086b to
2629849
Compare
|
Thanks for the suggestion. This makes it simpler. Let me know if this is according to expectations. |
Fixes ublue-os#2221 by picking the correct channel and by selecting the currently deployed version tag.
Fetching changelogs for various release channels from github is impossible and cannot be baked into the image ublue-os#2223.
mheuvel-dev
force-pushed
the
fix-changelog-url
branch
from
2629849 to
cd83f3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2221 by picking the correct channel and by selecting the currently deployed version tag.