Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update VFIO to be bootc compliant #2150

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Conversation

HikariKnight
Copy link
Member

This will be kept as a draft in-case more changes are needed, but from what i can tell, dracut is being run as part of the build process so the vfio modules should be included into initramfs with the image with this inclusion.

the just recipes and the script for kvmfr has been updated to reflect this

also minor changes to heredocs in some recipes to make the just highlighting work for me in vscode when writing this.
I will be making a similar PR to Aurora with the same updates later.

It is a tool that lists pci devices and which groups they are in, and it lets you use flags to fine tune what you look for and what info you want.
@HikariKnight HikariKnight marked this pull request as ready for review January 22, 2025 09:05
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. dx Developer Experience Image specific labels Jan 22, 2025
@HikariKnight HikariKnight requested a review from m2Giles January 22, 2025 09:07
@HikariKnight HikariKnight marked this pull request as draft January 24, 2025 08:29
@HikariKnight
Copy link
Member Author

putting back to draft as i remembered there is a part i forgot to move over from bazzite, so will work on that later today or in the weekend hopefully

@HikariKnight HikariKnight marked this pull request as ready for review January 29, 2025 07:24
@tulilirockz
Copy link
Collaborator

Is this good for merging? It looks good to me but I cant really test this on my machine.

@HikariKnight
Copy link
Member Author

HikariKnight commented Feb 7, 2025

Should be good to merge, but i will run a last test pass over it in a VM after i get home from work today just to be sure.

i will manually delete the branch after it is merged as i have to copy things over to aurora.

Urllink function cannot be the last "word" in the line as it will break formatting for some reason when run through a script.
@HikariKnight
Copy link
Member Author

@tulilirockz all cleaned up now :)

tulilirockz
tulilirockz previously approved these changes Feb 7, 2025
Copy link
Collaborator

@tulilirockz tulilirockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing seems wrong, if this causes issues people are gonna report it so its ok if its not working perfectly yet.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 7, 2025
easier to just have 1 script to update between bazzite, bluefin and aurora then.
@HikariKnight
Copy link
Member Author

Ported changes to aurora too, so safe to delete branch once merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer Experience Image specific lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants