Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new autumn wallpaper #1794

Merged
merged 5 commits into from
Oct 16, 2024
Merged

feat: new autumn wallpaper #1794

merged 5 commits into from
Oct 16, 2024

Conversation

Raindrac
Copy link
Collaborator

This commit contains a new autumn wallpaper commissioned by @castrojo. It also changes the default wallpaper to that new wallpaper and it creates a framework for easily dropping in new monthly wallpapers.

New monthly wallpapers can be added in by dropping them into /system_files/silverblue/usr/share/backgrounds/bluefin with the appropriate file name and then uncommenting the corresponding xml file located in
/system_files/silverblue/usr/share/gnome-background-properties. Nothing else needs to be done as everything else is prepped and ready to go.

The pcolor of every new wallpaper was set to #000000 so that, if for whatever reason a wallpaper fails to load, the problem is more obvious. Existing wallpapers were changed to match.

The following attachment is a spreadsheet that goes into detail about when day/night transitions occur for every month and the reason behind those decisions.

Bluefin Wallpaper Timings.ods

Raindrac added 3 commits October 16, 2024 00:58
This commit contains a new autumn wallpaper. It also changes the default
wallpaper to that new wallpaper and it creates a framework for easily
dropping in new monthly wallpapers.

New monthly wallpapers can be added in by dropping them into
`/system_files/silverblue/usr/share/backgrounds/bluefin` with the
appropriate file name and then uncommenting the corresponding xml file
located in
`/system_files/silverblue/usr/share/gnome-background-properties`.
Nothing else needs to be done as everything else is prepped and ready to
go.
Saving the image compression for a separate commit.
@Raindrac Raindrac requested a review from castrojo as a code owner October 16, 2024 18:41
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Oct 16, 2024
@castrojo
Copy link
Member

Hah, awesome! Can we get this going on the testing branch for a day or so?

@Raindrac
Copy link
Collaborator Author

That'd be fine, though do keep in mind that I've already tested it pretty extensively on some virtual machines. Might not be necessary? I'll leave it up to y'all!

@castrojo
Copy link
Member

Yeah I just wanna test once or twice in different time zones, I appreciate the level of science put into this!

castrojo
castrojo previously approved these changes Oct 16, 2024
Copy link
Member

@castrojo castrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weekly builds are already out the door, might as well go for it, I have time to test today

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 16, 2024
@castrojo castrojo added this pull request to the merge queue Oct 16, 2024
@castrojo castrojo removed this pull request from the merge queue due to a manual request Oct 16, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 16, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Oct 16, 2024
@Raindrac
Copy link
Collaborator Author

There we go. That should ensure backwards compatibility for users on the spring, summer and winter wallpapers. I'm going to leave the November wallpaper as-is; we can skip it by not changing the default until December and then merging in @p5's commit on December 1st so that it'll automatically switch from October to December.

@castrojo castrojo enabled auto-merge October 16, 2024 20:35
@castrojo castrojo added this pull request to the merge queue Oct 16, 2024
Merged via the queue into ublue-os:main with commit ff123d2 Oct 16, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants