Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable stable-daily channel #1779

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

befanyt
Copy link
Contributor

@befanyt befanyt commented Oct 13, 2024

I really liked the idea of having a daily build of the stable channel as of talked in #1736. So I tried my best to implement this feature.

Changes made:

  • Aurora & Bluefin stable workflow now scheduled to build everyday and let you specify a "weekly_tag_day".
  • If the workflow is not run via schedule, tag with stable and stable-daily.
  • If the workflow is run via schedule and matches the weekly_tag_day, tag with stable and stable-daily.
  • If the workflow is run via schedule but not matches the weekly_tag_day, tag with stable-daily.

Hope this is the correct implementation, thanks for this awesome project.

@befanyt befanyt requested a review from castrojo as a code owner October 13, 2024 20:42
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Oct 13, 2024
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good:

  • scheduled daily build of "stable" will result in tags: stable-daily and stable-daily-TIMESTAMP
  • scheduled weekly build of "stable" will result in tags: stable-daily,stable-daily-TIMESTAMP, stable,stable-TIMESTAMP
  • manual build will result in tags: stable-daily,stable-daily-TIMESTAMP, stable,stable-TIMESTAMP

In all cases the "DEFAULT_TAG" is stable-daily which i think is correct.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 13, 2024
@castrojo castrojo added this pull request to the merge queue Oct 13, 2024
@castrojo
Copy link
Member

This is awesome, thank you for this!

@bketelsen
Copy link
Member

oh sweeeeet!

@m2Giles
Copy link
Member

m2Giles commented Oct 14, 2024

Thank you for adding this!

@bsherman
Copy link
Contributor

@castrojo per our real-time chat, i think we may want an improvement where we can do a manual build which only regenerates a "stable-daily" and not a "stable-weekly" but that would also require a workflow specifically for the semi-rare scenarios where you need to manually build a weekly... and that would be extra logic in the tags.

Merged via the queue into ublue-os:main with commit 3201dd3 Oct 14, 2024
52 checks passed
@befanyt
Copy link
Contributor Author

befanyt commented Oct 14, 2024

Nice, now live from stable-daily! Let's see how this works out.

Oh I now see that it has been building iso's too. I'm not sure where that comes from as I didn't touch iso workflows. 😕
Found it, I will try if I can fix it.

if: (github.event_name == 'schedule' || github.event_name == 'workflow_dispatch') && (github.ref_name == 'main' || github.ref_name == 'testing') && inputs.fedora_version != 'beta' && inputs.fedora_version != 'latest'

Well, I'm really sorry, but I'm unable to fix the ISO building. There are too many variables that I'm not comfortable enough with.

Therefore, it might be better to revert this PR before it consumes all the resources.

@befanyt befanyt deleted the daily-stable branch October 14, 2024 08:18
@castrojo
Copy link
Member

Don't sweat the ISOs we can go back and clean those up, it's not burning through money. Though nothing got pushed to the bucket afaict.

(On stable-daily here too, nice!)

@castrojo
Copy link
Member

Ok so I totally love how this is working out. I keep my main PC on stable-daily because I gotta always have everything, but then keep the rest of my PCs on stable because that's also fine.

It's like a little sports mode button. 😈

@befanyt
Copy link
Contributor Author

befanyt commented Oct 17, 2024

Same here! Desktop pc on stable-daily and laptop on stable. Feels like the perfect combination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants