Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move files in /usr/etc to /etc #1580

Merged
merged 4 commits into from
Aug 9, 2024
Merged

fix: Move files in /usr/etc to /etc #1580

merged 4 commits into from
Aug 9, 2024

Conversation

KyleGospo
Copy link
Member

Adding files to /usr/etc is considered undefined behavior

@KyleGospo KyleGospo requested a review from castrojo as a code owner August 8, 2024 03:58
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working dx Developer Experience Image specific labels Aug 8, 2024
@castrojo
Copy link
Member

castrojo commented Aug 8, 2024

Ok I've removed all mentions of the etc-merge service. Please doublecheck my work.

@castrojo
Copy link
Member

castrojo commented Aug 9, 2024

This good to go or are we still sorting out that containers.json thing? (Does that even affect Bluefin since we're not using the rechunker?)

@p5
Copy link
Member

p5 commented Aug 9, 2024

This good to go or are we still sorting out that containers.json thing? (Does that even affect Bluefin since we're not using the rechunker?)

@castrojo The containers.json thing is only affecting main and ucore since this is where we add the container policy to the image by installing the ublue-is-signing RPM.

The issue there is we want to move the policy from /usr/etc to /etc, but Fedora's containers package already has taken "ownership" of that file, and doesn't allow us to overwrite it from our own RPM.

This has been reverted in ublue-os/config for now but I don't think we have any issues here.

@castrojo castrojo merged commit e1c6ffc into main Aug 9, 2024
54 checks passed
@castrojo castrojo deleted the usr-etc-to-usr branch August 9, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dx Developer Experience Image specific size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants