Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fead: Add dialog boxes #1532

Merged
merged 2 commits into from
Aug 4, 2024
Merged

fead: Add dialog boxes #1532

merged 2 commits into from
Aug 4, 2024

Conversation

lethedata
Copy link
Contributor

Add zenity and kdialog dialog boxes for silverblue and kinoite respectively to support distrobox rootful container gui applications.

Add zenity and kdialog dialog boxes for silverblue and kinoite respectively.
@lethedata lethedata requested a review from castrojo as a code owner July 23, 2024 22:17
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Jul 23, 2024
@lethedata
Copy link
Contributor Author

The specific reason for this is that distrobox_sudo_askpass is a file generated by distrobox-export which is for using commands other than sudeo to run a rootful container.12

Footnotes

  1. distrobox-export#L54

  2. Using a command other than sudo to run a rootful container

@m2Giles
Copy link
Member

m2Giles commented Jul 23, 2024

Gnome-ssh-askpass and ksshaskpass are both present for a graphical prompt.

You can also use polkit as well with either systemd-run or pkexec.

I'm unsure how these would be necessary for the specified use case of rootful distroboxes.

That said, both of these can be used to make simple graphical prompts for scripts.

@lethedata
Copy link
Contributor Author

Gnome-ssh-askpass and ksshaskpass are both present for a graphical prompt.

You can also use polkit as well with either systemd-run or pkexec.

I'm unsure how these would be necessary for the specified use case of rootful distroboxes.

The distrobox_sudo_askpass script is created by distrobox-export by default and used to ask for a password on exported apps. It seems to be distrobox's default way to ask for a sudo password outside of a terminal. Using one of those mentioned above is an option it just requires some manual intervention.

That said, both of these can be used to make simple graphical prompts for scripts.

I admit that this is probably better reasoning than distrobox specific. I mention distrobox because of above and it being bundled by default.

@m2Giles m2Giles changed the title Add dialog boxes fead: Add dialog boxes Jul 28, 2024
@castrojo castrojo enabled auto-merge August 4, 2024 13:17
@castrojo castrojo disabled auto-merge August 4, 2024 13:17
@castrojo castrojo merged commit ecbcdb0 into ublue-os:main Aug 4, 2024
32 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants