Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Update reusable-image-scan.yml to use lowercase registry name #1183

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix(ci): Update reusable-image-scan.yml to use lowercase registry name #1183

merged 1 commit into from
Apr 22, 2024

Conversation

apoordev
Copy link
Contributor

I was just having an issue with the image scan part of the github build actions. I was able to pinpoint the issue down to my github username having capital letters based on this error.

   - unable to parse registry reference="ghcr.io/APoorDev/aurora-asus@sha256:707967fb1d91da42774b8756c50c9df974919d1a84dd879ba7063c08aae99328": could not parse reference: ghcr.io/APoorDev/aurora-asus@sha256:707967fb1d91da42774b8756c50c9df974919d1a84dd879ba7063c08aae99328

I just stole the fix you all use in the reusable-build.yml and it was able to fix this error. Let me know if there is anything you would like changed or if I did something wrong!

P.S.
Awesome project, Ive been having a lot of fun messing with and learning github actions!

@apoordev apoordev requested a review from castrojo as a code owner April 22, 2024 17:20
Copy link
Member

@p5 p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@p5 p5 enabled auto-merge April 22, 2024 17:43
@p5 p5 changed the title fix: Update reusable-image-scan.yml to use lowercase registry name fix(ci): Update reusable-image-scan.yml to use lowercase registry name Apr 22, 2024
@p5 p5 added this pull request to the merge queue Apr 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2024
@p5 p5 merged commit 9c8f6de into ublue-os:main Apr 22, 2024
75 checks passed
@apoordev apoordev deleted the ublue-os-main branch April 22, 2024 21:40
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants