Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: source systemd-dx.sh from build-dx.sh script #1155

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

p5
Copy link
Member

@p5 p5 commented Apr 18, 2024

I feel this file should be sourced (and therefore executed) from the build-dx.sh file. This is why we have no Podman or Docker sockets enabled in DX.

@p5 p5 requested a review from castrojo as a code owner April 18, 2024 17:56
Copy link
Member

@bketelsen bketelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this.

@p5 p5 changed the title fix: source systemd-dx.sh from build-dx.sh file fix: source systemd-dx.sh from build-dx.sh script Apr 18, 2024
@bketelsen bketelsen enabled auto-merge April 18, 2024 17:57
@bketelsen bketelsen added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit 57fcbd3 Apr 18, 2024
70 checks passed
@bketelsen bketelsen deleted the enable-dx-systemd-services branch April 18, 2024 18:23
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants