Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aurora): Add Kde branding via a theme #1140

Merged
merged 3 commits into from
Apr 21, 2024
Merged

feat(aurora): Add Kde branding via a theme #1140

merged 3 commits into from
Apr 21, 2024

Conversation

m2Giles
Copy link
Member

@m2Giles m2Giles commented Apr 15, 2024

Used Steam's Vapor on making a theme.

@m2Giles m2Giles marked this pull request as ready for review April 15, 2024 20:56
@m2Giles m2Giles requested a review from castrojo as a code owner April 15, 2024 20:56
@m2Giles m2Giles changed the title Kde branding Feat: Kde branding via theme Apr 15, 2024
@@ -0,0 +1,4 @@
applet.wallpaperPlugin = 'org.kde.image'
applet.currentConfigGroup = ["Wallpaper", "org.kde.image", "General"]
applet.writeConfig("Image", "/usr/share/wallpapers/jonatan-pie-aurora.jpg")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found a critical Error Prone issue: 'applet' is not defined.

The issue that ESLint is reporting indicates that the variable applet has not been defined in the scope of the code provided. This means that before we attempt to set properties or call methods on applet, we must ensure that it has been declared and assigned a value that represents the object we want to interact with.

Since I don't have the full context of where and how applet should be defined, I'll provide a generic fix that assumes applet should be an object with the methods and properties you're trying to use. In a real-world scenario, you would need to define applet appropriately based on the surrounding code and the API you're working with.

Here's the code suggestion to define applet:

Suggested change
applet.writeConfig("Image", "/usr/share/wallpapers/jonatan-pie-aurora.jpg")
var applet = {};

You would place this line before the first use of applet to ensure it's defined. However, keep in mind that this is a placeholder solution. In actual practice, applet should be defined in a way that makes sense for your application, and it should be an object that has the wallpaperPlugin, currentConfigGroup, writeConfig, and reloadConfig properties and methods available. If applet is supposed to be provided by some framework or library, you'll need to ensure that the library is included and that applet is obtained correctly from it.


This comment was generated by an experimental AI tool.

applet.wallpaperPlugin = 'org.kde.image'
applet.currentConfigGroup = ["Wallpaper", "org.kde.image", "General"]
applet.writeConfig("Image", "/usr/share/wallpapers/jonatan-pie-aurora.jpg")
applet.reloadConfig()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found a critical Error Prone issue: 'applet' is not defined.

The issue here is that the variable applet is being used without being defined within the scope of the code provided. This would result in a runtime error because JavaScript does not know what applet refers to. To fix this issue, you need to ensure that applet is defined before you try to access its properties and methods.

Since I don't have the full context of where applet should be coming from (e.g., whether it's supposed to be a global variable, or it should be passed as a function parameter, etc.), I'll provide a generic fix. If applet is expected to be a global object provided by some external script or environment (like a KDE Plasma environment), you should check if applet is actually available in your current scope.

Assuming applet should be available globally, a defensive programming approach would be to check if applet is defined before attempting to call reloadConfig on it. Here's a single line change that adds a guard to prevent the error:

Suggested change
applet.reloadConfig()
if (applet) applet.reloadConfig();

However, if applet is meant to be defined elsewhere in your code, you would need to ensure that the definition is present and correct. If it's missing entirely, you would need to define it appropriately, but since you've asked for a single line change, the above suggestion is the best I can provide without additional context.


This comment was generated by an experimental AI tool.

@@ -0,0 +1,3 @@
applet.currentConfigGroup = ["General"]
applet.writeConfig("icon", "distributor-logo")
applet.reloadConfig()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found a critical Error Prone issue: 'applet' is not defined.

The issue here is that the variable applet has not been declared within the scope that this code is running, which means that JavaScript does not know what applet refers to. This could lead to a ReferenceError at runtime when the script tries to access a property or call a method on an undefined variable.

To fix the issue, you would need to ensure that applet is properly defined before this code fragment is executed. This could mean different things depending on the context in which this code is running:

  1. If applet is supposed to be a global variable that's defined in another script, make sure that script is loaded before this one.
  2. If applet is supposed to be passed into the function or block of code where this fragment is located, ensure it is included in the parameters or that it's within the correct scope.
  3. If applet is an object that should be created within this scope, you'll need to define it.

Without additional context, I can provide a generic suggestion to define applet as an empty object before trying to assign properties to it. Here's a single line change that defines applet before attempting to access its properties:

Suggested change
applet.reloadConfig()
var applet = applet || {}; // Define applet if it's not already defined

This line checks if applet is already defined; if not, it initializes applet as an empty object. However, please note that this is a generic fix and the actual solution might require a more specific approach depending on the context in which applet is used.


This comment was generated by an experimental AI tool.

@@ -0,0 +1,4 @@
applet.wallpaperPlugin = 'org.kde.image'
applet.currentConfigGroup = ["Wallpaper", "org.kde.image", "General"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found a critical Error Prone issue: 'applet' is not defined.

The issue indicated by ESLint is that the variable applet is being used without being defined within the scope of the JavaScript code. This could be because applet is supposed to be a global variable that has not been declared, or it's an object that should have been passed into the current context but wasn't.

In a browser environment, using an undefined variable will result in a ReferenceError. However, if applet is intended to be a global object provided by the environment in which the code is running (such as a KDE Plasma desktop widget), then the issue might be that ESLint isn't aware of this environment-specific global.

If applet is indeed meant to be a global object provided by the KDE Plasma environment, you can inform ESLint about this global variable by adding a comment at the top of your file to indicate that applet is a global variable. Here is the code suggestion to declare applet as a global variable for ESLint:

Suggested change
applet.currentConfigGroup = ["Wallpaper", "org.kde.image", "General"]
/* global applet */

If applet is not supposed to be a global variable and needs to be defined within your script or module, you would have to instantiate or import it before using it. However, since you've asked for a single line change, the above suggestion is the most appropriate under the assumption that applet is an environment-specific global.


This comment was generated by an experimental AI tool.

@@ -0,0 +1,4 @@
applet.wallpaperPlugin = 'org.kde.image'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found a critical Error Prone issue: 'applet' is not defined.

The issue here is that the variable applet is being used without being defined, which means that the script is trying to assign a property to an identifier that has not been declared. This can lead to a runtime error if applet does not exist in the scope in which this code is running.

In a browser environment, this would typically mean that applet needs to be defined globally or within the scope of where this code is running. However, since the naming and structure suggest that this code is related to a KDE Plasma desktop widget, applet is likely meant to be a predefined object provided by the Plasma framework.

If applet is supposed to be a global object provided by the environment (like KDE Plasma), ensure that the script is running in the correct context where applet is already defined.

If applet is actually meant to be a local variable that you need to define, you would need to declare it before using it. Assuming that applet should be an object that you'll be setting properties on, here's how you could define it:

Suggested change
applet.wallpaperPlugin = 'org.kde.image'
let applet = {};

This line should be placed before the first use of applet. However, if applet is indeed supposed to be a global object provided by the Plasma environment, then you should check the environment setup to ensure that the script is being executed in a context where applet is already defined. If it's part of a module or a larger script, you might need to pass applet as a parameter to the function or ensure it's imported or included correctly.


This comment was generated by an experimental AI tool.

@@ -0,0 +1,3 @@
applet.currentConfigGroup = ["General"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found a critical Error Prone issue: 'applet' is not defined.

The issue here is that the variable applet has not been defined within the current scope, which means that the code is trying to assign a property to an undefined variable. This will lead to a runtime error if the code is executed as-is.

To fix this issue, you need to ensure that applet is properly defined before you try to access its properties or methods. The definition of applet will depend on the context in which this code is running. For instance, if applet is supposed to be a global variable that has been defined elsewhere, you need to make sure that the script that defines applet is loaded before this code runs.

If applet is supposed to be a local variable within a function or a module, you need to define it within that scope. Since I don't have the full context, I'll provide a generic suggestion assuming that applet should be an object with a property currentConfigGroup and methods writeConfig and reloadConfig.

Here's the code suggestion to define applet as an empty object before setting its currentConfigGroup property:

Suggested change
applet.currentConfigGroup = ["General"]
let applet = {};

Please note that you may need to adjust this suggestion based on the actual context in which applet is being used. If applet is an instance of a class, you would need to instantiate it accordingly, or if it's an imported module, you would need to import it before use.


This comment was generated by an experimental AI tool.

@@ -0,0 +1,6 @@
systemtrayId = applet.readConfig("SystrayContainmentId");
if (systemtrayId) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found a critical Error Prone issue: 'systemtrayId' is not defined.

The issue identified by ESLint is that the variable systemtrayId is being used without being defined within the current scope or in any parent scope accessible to this code fragment. JavaScript requires that variables are declared before they are used to avoid reference errors and to make code more readable and maintainable.

To fix this issue, you should ensure that systemtrayId is declared with let, const, or var (depending on the intended scope and reassignment needs) before it is used. Since the code snippet doesn't show where systemtrayId is supposed to come from, I'll assume it should be retrieved from applet and declared as a new variable in the current scope. Here's the code suggestion:

Suggested change
if (systemtrayId) {
let systemtrayId = applet.readConfig("SystrayContainmentId");

This comment was generated by an experimental AI tool.

@@ -0,0 +1,3 @@
applet.currentConfigGroup = ["General"]
applet.writeConfig("icon", "distributor-logo")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found a critical Error Prone issue: 'applet' is not defined.

The issue here is that the variable applet is being used without being defined in the scope of the code provided. This could mean that applet is expected to be a global variable that has not been declared, or it was supposed to be an object provided by some context not shown in the code snippet.

To fix the issue, you would need to ensure that applet is defined before this code fragment runs. This might involve importing applet from another module, or defining it within the scope if it's missing. However, without additional context, it's impossible to provide a precise solution.

Assuming applet should be a global variable that was supposed to be defined elsewhere in your application, you might need to check other parts of your code to make sure applet is correctly imported or declared.

If applet is indeed supposed to be a global variable, and you are certain that it is being defined elsewhere correctly, you can inform ESLint that applet is a global variable by adding a comment at the top of your file:

Suggested change
applet.writeConfig("icon", "distributor-logo")
/* global applet */

This comment tells ESLint that applet is a global variable and is expected to be defined in some other part of your application or by the environment your script is running in. If applet is not supposed to be a global, you'll need to adjust your code to properly define or import it.


This comment was generated by an experimental AI tool.

@@ -0,0 +1,6 @@
systemtrayId = applet.readConfig("SystrayContainmentId");
if (systemtrayId) {
const systrayContainer = desktopById(systemtrayId);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found a critical Error Prone issue: 'desktopById' is not defined.

The issue here is that the function desktopById is being called, but it has not been defined in the scope of the current code fragment. This will lead to a runtime error because the JavaScript interpreter does not know what desktopById refers to.

To fix this issue, you need to ensure that desktopById is available in the scope where you are trying to use it. This could mean importing it from another module if it's defined elsewhere, or defining the function if it's missing.

Assuming that desktopById is a function that should be imported from another module, the fix would be to add an import statement at the beginning of the file. Here's a suggestion assuming desktopById is exported from a module named 'desktopUtils':

Suggested change
const systrayContainer = desktopById(systemtrayId);
import { desktopById } from 'desktopUtils';

This comment was generated by an experimental AI tool.

@@ -0,0 +1,6 @@
systemtrayId = applet.readConfig("SystrayContainmentId");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy found a critical Error Prone issue: 'systemtrayId' is not defined.

The issue here is that the variable systemtrayId is being assigned a value without being declared first. In JavaScript, if you assign a value to an undeclared variable, it will implicitly create a global variable, which can lead to unexpected behavior and bugs. To adhere to best practices and avoid such issues, variables should be declared with var, let, or const before being used.

Here's the single line code suggestion to fix the issue:

Suggested change
systemtrayId = applet.readConfig("SystrayContainmentId");
let systemtrayId = applet.readConfig("SystrayContainmentId");

By adding let before systemtrayId, we are declaring the variable in the local scope, which is a safer and more predictable way to handle variables in JavaScript. If systemtrayId is meant to be immutable and not reassigned, you could use const instead of let.


This comment was generated by an experimental AI tool.

@NiHaiden NiHaiden changed the title Feat: Kde branding via theme feat(aurora): Add Kde branding via a theme Apr 20, 2024
@m2Giles m2Giles merged commit 80a3213 into main Apr 21, 2024
65 of 70 checks passed
@m2Giles m2Giles deleted the kde-branding branch April 21, 2024 16:42
awesomekyle pushed a commit to awesomekyle/bluefin that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants