Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use official upstream images for kmod builds #85

Merged
merged 3 commits into from
Nov 1, 2023
Merged

feat: use official upstream images for kmod builds #85

merged 3 commits into from
Nov 1, 2023

Conversation

bsherman
Copy link
Contributor

@bsherman bsherman commented Nov 1, 2023 •
edited
Loading

This change does two things:

  1. uses official upstream silverblue image, rather than the QA build of base, as our builder
  2. changes cron to 1400 UTC to more closely match the time of official image builds

This change matches with the changes in ublue-os/main#407

@bsherman bsherman requested a review from a team November 1, 2023 03:11
@bsherman bsherman requested a review from castrojo as a code owner November 1, 2023 03:11
@bsherman
feat(f39): use official upstream image for akmods builds
b05d601 
Moving to official upstream images for `main` also implies the use of
the official image's kernel for akmods builds.
@bsherman
fix: missing double quotes
ca1186e
@bsherman bsherman changed the title feat: change cron to 1400 UTC for official image build timing feat: use official upstream images for kmod builds Nov 1, 2023
@castrojo castrojo enabled auto-merge November 1, 2023 03:33
EyeCantCU
EyeCantCU approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@castrojo castrojo added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit 9216bb2 Nov 1, 2023
17 of 20 checks passed
@castrojo castrojo deleted the official-image-cron branch November 1, 2023 04:05
@github-actions github-actions bot mentioned this pull request Oct 30, 2023
Closed
@github-actions github-actions bot mentioned this pull request Dec 5, 2023
Closed
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EyeCantCU EyeCantCU EyeCantCU approved these changes

@castrojo castrojo castrojo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsherman @castrojo @EyeCantCU