Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable preview of Fedora 40 kmod builds #143

Merged
merged 5 commits into from
Mar 17, 2024
Merged

feat: enable preview of Fedora 40 kmod builds #143

merged 5 commits into from
Mar 17, 2024

Conversation

bsherman
Copy link
Contributor

@bsherman bsherman commented Mar 17, 2024

This enables Fedora 40 builds, but filters out known problems.

Specifically, when the build version is Fedora 40, this disables several kmods which are either not yet available for Fedora 40 in upstream repos or do not currently compile against Fedora 40.

The disabled kmod list:

  • evdi: negativo17 does not yet provide F40
  • gasket: compile failure
  • nvidia-470xx: compile failure
  • rtl18814au: compile failure
  • rtl188xxau: compile failure
  • v4l2loopback: compile failure
  • xpadneo: negativo17 does not yet provide F40

I also standardized a small change to the build-kmod scripts. We now copy/activate extra yum repo files only after getting the Fedora release variable which make things simpler when needing to bail out early due to known issues with F40, etc.

This enables Fedora 40 builds, but filters out problems.

Specifically, when the build version is Fedora 40, this
disables several kmods which are either not yet available
for Fedora 40 in upstream repos or do not currently
compile against Fedora 40.

The disabled kmod list:
- evdi: negativo17 does not yet provide F40
- gasket: compile failure
- rtl18814au: compile failure
- rtl188xxau: compile failure
- v4l2loopback: compile failure
- xpadneo: negativo17 does not yet provide F40

I also standardized a small change to the build-kmod scripts.
We now copy/activate extra yum repo files only after getting
the Fedora release variable which make things simpler when
needing to bail out early due to known issues with F40, etc.
Copy link
Member

@p5 p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the builds are green.

Created a tracking issue so we can monitor the rollout to the remaining akmods
#144

@KyleGospo
Copy link
Member

We can likely drop xpadneo entirely. Xone and xpad should cover 99% of the use case, Bazzite for instance doesn't ship xpadneo.

I will look into Gasket since that's my pet

@bsherman
Copy link
Contributor Author

bsherman commented Mar 17, 2024

We can likely drop xpadneo entirely. Xone and xpad should cover 99% of the use case, Bazzite for instance doesn't ship xpadneo.

I will look into Gasket since that's my pet

xpadneo is the bluetooth support for xone ... what do you use instead?

edit: read-between the lines :-) I use xpadneo a lot

@bsherman
Copy link
Contributor Author

FYI all approvers, I'm fixing more workflow stuff as the PR checks build has shown some gaps in my local testing.

@KyleGospo
Copy link
Member

KyleGospo commented Mar 17, 2024

xpadneo is the bluetooth support for xone ... what do you use instead?

We only ship xpad and xone and haven't had complaints. I think Steam does something in user space.

@bsherman
Copy link
Contributor Author

xpadneo is the bluetooth support for xone ... what do you use instead?

We only ship xpad and xone and haven't had complaints. I think Steam does something in user space.

Fair enough. I'm open to considering removal as part of another discussion where we test it out, but I'd rather not make the decision as part of this PR.

@KyleGospo
Copy link
Member

KyleGospo commented Mar 17, 2024 via email

bsherman and others added 3 commits March 17, 2024 12:58
Co-authored-by: Kyle Gospodnetich <[email protected]>
Co-authored-by: Benjamin Sherman <[email protected]>
- remove surface exclusion as it now builds on F40
- update reason for excluding nvidia 470 on F40
- update excluded fsync version
@bsherman
Copy link
Contributor Author

Apparently I broke something in the F38/F39 common akmod builds. 😨

Trying to track that down and fix it, then this should be good to go with the caveats listed above and in the related #144

@bsherman bsherman self-assigned this Mar 17, 2024
@bsherman bsherman added the enhancement New feature or request label Mar 17, 2024
@bsherman bsherman enabled auto-merge March 17, 2024 19:20
@bsherman
Copy link
Contributor Author

Ok! This is looking good now!

@bsherman bsherman requested a review from a team March 17, 2024 19:24
@bsherman bsherman added this pull request to the merge queue Mar 17, 2024
Merged via the queue into main with commit 1242246 Mar 17, 2024
24 checks passed
@bsherman bsherman deleted the f40-preview branch March 17, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants