-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable preview of Fedora 40 kmod builds #143
Conversation
This enables Fedora 40 builds, but filters out problems. Specifically, when the build version is Fedora 40, this disables several kmods which are either not yet available for Fedora 40 in upstream repos or do not currently compile against Fedora 40. The disabled kmod list: - evdi: negativo17 does not yet provide F40 - gasket: compile failure - rtl18814au: compile failure - rtl188xxau: compile failure - v4l2loopback: compile failure - xpadneo: negativo17 does not yet provide F40 I also standardized a small change to the build-kmod scripts. We now copy/activate extra yum repo files only after getting the Fedora release variable which make things simpler when needing to bail out early due to known issues with F40, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the builds are green.
Created a tracking issue so we can monitor the rollout to the remaining akmods
#144
We can likely drop xpadneo entirely. Xone and xpad should cover 99% of the use case, Bazzite for instance doesn't ship xpadneo. I will look into Gasket since that's my pet |
xpadneo is the bluetooth support for xone ... what do you use instead? edit: read-between the lines :-) I use xpadneo a lot |
FYI all approvers, I'm fixing more workflow stuff as the PR checks build has shown some gaps in my local testing. |
We only ship xpad and xone and haven't had complaints. I think Steam does something in user space. |
Fair enough. I'm open to considering removal as part of another discussion where we test it out, but I'd rather not make the decision as part of this PR. |
We only ship xpad and xone and haven't had complaints. I think Steam does something in user space.
…On Mar 17, 2024, 10:42 AM -0700, Benjamin Sherman ***@***.***>, wrote:
> We can likely drop xpadneo entirely. Xone and xpad should cover 99% of the use case, Bazzite for instance doesn't ship xpadneo.
> I will look into Gasket since that's my pet
xpadneo is the bluetooth support for xone ... what do you use instead?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Co-authored-by: Kyle Gospodnetich <[email protected]> Co-authored-by: Benjamin Sherman <[email protected]>
- remove surface exclusion as it now builds on F40 - update reason for excluding nvidia 470 on F40 - update excluded fsync version
Apparently I broke something in the F38/F39 common akmod builds. 😨 Trying to track that down and fix it, then this should be good to go with the caveats listed above and in the related #144 |
Ok! This is looking good now! |
This enables Fedora 40 builds, but filters out known problems.
Specifically, when the build version is Fedora 40, this disables several kmods which are either not yet available for Fedora 40 in upstream repos or do not currently compile against Fedora 40.
The disabled kmod list:
I also standardized a small change to the build-kmod scripts. We now copy/activate extra yum repo files only after getting the Fedora release variable which make things simpler when needing to bail out early due to known issues with F40, etc.