Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/616 #825

Merged
merged 14 commits into from
Oct 24, 2023
Merged

Feature/616 #825

merged 14 commits into from
Oct 24, 2023

Conversation

rndquu
Copy link
Member

@rndquu rndquu commented Oct 24, 2023

Resolves #616

@ubiquibot
Copy link

ubiquibot bot commented Oct 24, 2023 •
edited
Loading

@rndquu
Copy link
Member Author

rndquu commented Oct 24, 2023

@molecula451 I have no idea how the "Compare Test Coverage" workflow calculates the following values and fails afterwards:

Development branch coverage: 69.1
PR branch coverage: 10.1

I will raise a bug in a separate issue.

@rndquu rndquu marked this pull request as ready for review October 24, 2023 13:27
@rndquu rndquu requested a review from molecula451 October 24, 2023 13:27
@molecula451
Copy link
Contributor

@molecula451 I have no idea how the "Compare Test Coverage" workflow calculates the following values and fails afterwards:

Development branch coverage: 69.1
PR branch coverage: 10.1

I will raise a bug in a separate issue.

i think it will fine to have a branch coverage issue as this architecture in the workflow looks a bit outdated, leading to this failing compared test coverages

@rndquu rndquu requested a review from molecula451 October 24, 2023 15:13
molecula451
molecula451 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@molecula451 molecula451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

litte script to fetch the facets selectors from facet working nice, overall good code

@molecula451 molecula451 enabled auto-merge (squash) October 24, 2023 15:28
@molecula451 molecula451 merged commit 7c3a0bb into ubiquity:development Oct 24, 2023
@rndquu rndquu deleted the feature/616 branch October 24, 2023 15:30
@rndquu rndquu mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molecula451 molecula451 molecula451 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatic selector populating for diamond facets
2 participants
@rndquu @molecula451