feat: polish storage-check

ubiquity · Oct 19, 2024 · c95eaa0 · c95eaa0
1 parent b44ea46
commit c95eaa0
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 26 deletions.
diff --git a/.github/workflows/core-contracts-storage-check.yml b/.github/workflows/core-contracts-storage-check.yml
@@ -4,7 +4,6 @@ on:
   push:
     branches:
       - development
-      - fix-core-contracts-storage-check
   pull_request:
 
 jobs:
@@ -15,8 +14,7 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: recursive
-          fetch-depth: 2  # Ensure we can access the previous commit
-
+
       - name: Install Foundry
         uses: onbjerg/foundry-toolchain@v1
         with:

diff --git a/.github/workflows/diamond-storage-check.yml b/.github/workflows/diamond-storage-check.yml
@@ -4,7 +4,6 @@ on:
   push:
     branches:
       - development
-      - fix-core-contracts-storage-check
     paths:
       - '**.sol'
   pull_request:
@@ -19,7 +18,6 @@ jobs:
       - uses: actions/checkout@v4
         with:
           submodules: recursive
-          fetch-depth: 2
 
       - name: Install Foundry
         uses: onbjerg/foundry-toolchain@v1

diff --git a/packages/contracts/src/dollar/core/ERC20Ubiquity.sol b/packages/contracts/src/dollar/core/ERC20Ubiquity.sol
@@ -25,8 +25,6 @@ abstract contract ERC20Ubiquity is
     ERC20PermitUpgradeable,
     ERC20PausableUpgradeable
 {
-    // this is a non-colliding change
-
     /// @notice Token symbol
     string private _symbol;
 

diff --git a/packages/contracts/src/dollar/core/ThisIsATest.sol b/packages/contracts/src/dollar/core/ThisIsATest.sol
diff --git a/packages/contracts/src/dollar/libraries/LibAppStorage.sol b/packages/contracts/src/dollar/libraries/LibAppStorage.sol
@@ -7,8 +7,6 @@ import "./Constants.sol";
 
 /// @notice Shared struct used as a storage in the `LibAppStorage` library
 struct AppStorage {
-    // this is a non-colliding change
-
     // reentrancy guard
     uint256 reentrancyStatus;
     // others

diff --git a/packages/contracts/src/dollar/libraries/LibThisIsATest.sol b/packages/contracts/src/dollar/libraries/LibThisIsATest.sol