Include type information in the package. Partial review of comments #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e it is false by default).
… false by default).
… false by default).
8845musign
commented
Nov 15, 2024
| @@ -65,7 +65,6 @@ type BaseProps = { | |||
| open?: boolean; | |||
| /** | |||
| * openを無視してモーダルを開いたままにするかどうか。アニメーションライブラリとの連携で、ActionHalfModal自身が開閉に関与しない場合に使用 | |||
There was a problem hiding this comment.
Boolean props with a default value of false are more about turning an option on than setting a value,
so I've decided to unify the direction of not writing default values.
| @@ -52,10 +49,9 @@ type Props = { | |||
| * 幅を指定。fullは後方互換のために残している | |||
| * デフォルト<Flex>は横幅いっぱいを専有する。しかし例えば、フレックスコンテナの子要素として配置した場合、横幅が自身の子に合わせて小さくなる。これが不都合の場合に100%とする | |||
| */ | |||
| width?: 'full' | Width; | |||
| width?: 'full' | CSSWitdh; | |||
There was a problem hiding this comment.
The content is the same. I've changed it to use the direct type.
| /** | ||
| * 無効状態かどうか | ||
| * @default false | ||
| */ | ||
| disabled?: boolean; | ||
| } & Omit<InputHTMLAttributes<HTMLInputElement>, 'children' | 'onChange'> & | ||
| } & Omit<InputHTMLAttributes<HTMLInputElement>, 'children'> & |
There was a problem hiding this comment.
I had redefined the props to write an explanation of onChange, but I stopped.
| | CSSLengthPercentage | ||
| | 'min-content' | ||
| | 'max-content' | ||
| | 'fit-content' | ||
| | `fit-content(${CSSLengthPercentage})` | ||
| | CSSVariable; | ||
|
|
||
| export type CSSMinWidth = | ||
| | 'auto' | ||
| export type CSSMaxWidth = |
There was a problem hiding this comment.
The initial value of max-width is none, not auto.
https://developer.mozilla.org/ja/docs/Web/CSS/max-width
There was a problem hiding this comment.
The type is incorrect, and the default value for the implementation is none
takanorip
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Check