Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gap alias prop to Stack Component #138

Merged
merged 2 commits into from
Nov 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/components/Box/Box.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,25 @@
import clsx from 'clsx';
import styles from './Box.module.css';
import {
paddingVariables,
marginVariables,
radiusVariables,
colorVariable,
cssFontSizeToken,
cssLeadingToken,
colorVariable,
marginVariables,
paddingVariables,
radiusVariables,
widthVariables,
} from '../../utils/style';
import { HTMLTagname } from '../../utils/types';
import type { CustomDataAttributeProps } from '../../types/attributes';
import type {
PaddingProps,
MarginProps,
RadiusProp,
BackgroundColor,
TextType,
TextColor,
BodyFontSize,
BodyLeading,
MarginProps,
PaddingProps,
RadiusProp,
TextColor,
TextType,
WidthProps,
} from '../../types/style';
import type { CSSProperties, FC, ReactNode } from 'react';
Expand All @@ -48,7 +48,7 @@ type BaseProps = {
border?: 'gray' | 'grayThick' | 'primary' | 'primaryThick';
/**
* 幅を指定。fullは後方互換のため残している
* @defaultValue 'autp'
* @default 'auto'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A follow-up correction.
@defaultValue is a tsdoc specification. However, this description is not extracted correctly by vitals.

*/
width?: 'full' | Width;
/**
Expand Down
4 changes: 2 additions & 2 deletions src/components/FlexItem/FlexItem.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use client';

import { clsx } from 'clsx';
import { CSSProperties, forwardRef, type PropsWithChildren, type HTMLAttributes } from 'react';
import { CSSProperties, forwardRef, type HTMLAttributes, type PropsWithChildren } from 'react';
import styles from './FlexItem.module.css';
import { CSSWitdh, MarginProps, PaddingProps, WidthProps } from '../../types/style';
import { marginVariables, paddingVariables } from '../../utils/style';
Expand All @@ -17,7 +17,7 @@ type AllowedDivAttributes = Omit<HTMLAttributes<HTMLDivElement>, 'className'>;
type Props = {
/**
* flexの値を指定。 growなどを指定したい場合はオブジェクトで指定
* @defaultValue none
* @default none
*/
flex?: 'none' | FlexProperty;
} & Omit<WidthProps, 'width'> &
Expand Down
52 changes: 40 additions & 12 deletions src/components/Stack/Stack.tsx
Original file line number Diff line number Diff line change
@@ -1,27 +1,22 @@
'use client';

import { clsx } from 'clsx';
import { isValidElement, cloneElement } from 'react';
import { cloneElement, isValidElement, useMemo } from 'react';
import styles from './Stack.module.css';
import { CustomDataAttributeProps } from '../../types/attributes'; // 追加したインポート
import { Spacing, AlignItems, JustifyContent, WidthProps } from '../../types/style';
import { paddingVariables, marginVariables, gapVariables, widthVariables } from '../../utils/style';
import { AlignItems, JustifyContent, Spacing, WidthProps } from '../../types/style';
import { gapVariables, marginVariables, paddingVariables, widthVariables } from '../../utils/style';
import { HTMLTagname } from '../../utils/types';
import { Box } from '../Box/Box';
import type { PaddingProps, MarginProps } from '../../types/style';
import type { FC, ReactNode, ComponentType, ReactElement } from 'react';
import type { MarginProps, PaddingProps } from '../../types/style';
import type { ComponentType, FC, ReactElement, ReactNode } from 'react';

type Props = {
/**
* レンダリングされるコンポーネントまたはHTML要素
* @default div
*/
as?: HTMLTagname | ReactElement<ComponentType<typeof Box>>;
/**
* 子要素の間隔。指定しない場合は0
* xxs=4px, xs=8px, sm=12px, md=16px, lg=24px, xl=40px, xxl=64px
*/
spacing?: Spacing;
/**
* 水平方向における子要素のレイアウトを定める。
* @default stretch
Expand All @@ -41,7 +36,29 @@ type Props = {
* 子要素
*/
children: ReactNode;
} & MarginProps &
} & (
| {
/**
* 子要素の間隔。指定しない場合は0
* xxs=4px, xs=8px, sm=12px, md=16px, lg=24px, xl=40px, xxl=64px
*/
spacing: Spacing;
gap?: never;
}
| {
/**
* spacingのエイリアス(どちらかしか指定できません)
* xxs=4px, xs=8px, sm=12px, md=16px, lg=24px, xl=40px, xxl=64px
*/
gap: Spacing;
spacing?: never;
}
| {
gap?: never;
spacing?: never;
}
) &
MarginProps &
PaddingProps &
WidthProps &
CustomDataAttributeProps;
Expand All @@ -55,6 +72,7 @@ export const Stack: FC<Props> = ({
children,
className,
spacing,
gap,
alignItems = 'stretch',
justifyContent = 'flex-start',
p,
Expand Down Expand Up @@ -85,13 +103,23 @@ export const Stack: FC<Props> = ({
}
};

const _spacing = useMemo(() => {
if (gap != null) {
return gap;
} else if (spacing != null) {
return spacing;
} else {
return undefined;
}
}, [gap, spacing]);

return createElement(
{
className: clsx(className, styles.stack),
style: {
alignItems: `${alignItems}`,
justifyContent: `${justifyContent}`,
...gapVariables(spacing),
...gapVariables(_spacing),
...paddingVariables({
p,
px,
Expand Down
24 changes: 23 additions & 1 deletion src/stories/Stack.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Meta, StoryObj } from '@storybook/react';
import { Stack, Box } from '..';
import { Box, Stack } from '..';
import { Spacing } from '../types/style';

export default {
Expand Down Expand Up @@ -140,3 +140,25 @@ export const Width: Story = {
),
args: defaultArgs,
};

export const Gap: Story = {
render: () => (
<Stack spacing="md">
<p style={{ margin: 0 }}>Text</p>
<p style={{ margin: 0 }}>Text</p>
<p style={{ margin: 0 }}>Text</p>
<p style={{ margin: 0 }}>Text</p>
</Stack>
),
};

export const NoSpacing: Story = {
render: () => (
<Stack>
<p style={{ margin: 0 }}>Text</p>
<p style={{ margin: 0 }}>Text</p>
<p style={{ margin: 0 }}>Text</p>
<p style={{ margin: 0 }}>Text</p>
</Stack>
),
};
6 changes: 3 additions & 3 deletions src/types/style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -195,17 +195,17 @@ export type CSSMinWidth =
export type WidthProps = {
/**
* 幅を指定
* @defaultValue auto
* @default auto
*/
width?: CSSWitdh;
/**
* 最小幅
* @defaultValue auto
* @default auto
*/
minWidth?: CSSMinWidth;
/**
* 最大幅
* @defaultValue none
* @default none
*/
maxWidth?: CSSMaxWidth;
};