Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figmaから出力するtokenのKeyをkebab caseに統一 #23

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

jmblog
Copy link
Contributor

@jmblog jmblog commented Aug 16, 2022

tokens/**/*.json の key を kebab case に統一した

{
  "color": {
    "Ubie": {
      "Black": {
        "100": { "value": "#16191f0a" }
      }
    }
  }
}
{
  "color": {
    "Background Accent": { "value": "{color.Ubie.Pink.100.value}" }
  }
}

{
  "color": {
    "ubie": {
      "black": {
        "100": { "value": "#16191f0a" }
      }
    }
  }
}
{
  "color": {
    "background-accent": { "value": "{color.ubie.pink.100.value}" }
  }
}

@jmblog jmblog changed the title Figmaから出力するtokenのKeyを小文字に統一 Figmaから出力するtokenのKeyをkebab caseに統一 Aug 16, 2022
Copy link
Contributor

@takanorip takanorip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takanorip takanorip merged commit b9fe935 into main Aug 17, 2022
@takanorip takanorip deleted the to-lower-case branch August 17, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants