Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config and assets dirs to cmake install directory directive #28

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

LeroyR
Copy link
Contributor

@LeroyR LeroyR commented Oct 11, 2023

😃

@rhaschke
Copy link
Member

I don't see the need to install the config and assets folders, they only comprise development files, don't they?
Why is the current handling of GLFW not sufficient in your point of view?

@LeroyR
Copy link
Contributor Author

LeroyR commented Oct 11, 2023

the launchfile defaults to files from these folders so assets and config should also be installed (or the launchfile defaults changed)

Also testxml is not installed and thus generate an error message.

Why is the current handling of GLFW not sufficient in your point of view?

removed for now, just generates stupid hints in RDTK

 No provider for LIBRARY libglfw.so.3

@DavidPL1
Copy link
Contributor

the launchfile defaults to files from these folders so assets and config should also be installed (or the launchfile defaults changed)

Yes, the proposed change is valid, they should be installed.

Also testxml is not installed and thus generate an error message.

I did not include this as this plugin is only built and utilized during testing. I'm not sure if catkin lint allows settings an exception for such a case. There are a few more catkin lint errors anyways that I will fix soon, so this will be handled.

@DavidPL1 DavidPL1 changed the title make mujoco useable after install Add config and assets dirs to cmake install directory directive Oct 11, 2023
@DavidPL1 DavidPL1 merged commit ce76ae6 into ubi-agni:noetic-devel Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants