Skip to content

Commit

Permalink
gh: fix docker settings for CI
Browse files Browse the repository at this point in the history
  • Loading branch information
DavidPL1 committed Jul 31, 2024
1 parent 6b3dc06 commit d81262b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
ARG IMAGE_PREFIX=""
ARG ROS_DISTRO=noetic
FROM ${IMAGE_PREFIX}ros:${ROS_DISTRO}-ros-base AS base
ARG BASE_DOCKER_NAME=${ROS_DISTRO}
FROM ${IMAGE_PREFIX}ros:${BASE_DOCKER_NAME}-ros-base AS base

ENV TERM xterm
ENV IN_DOCKER 1
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/docker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ROS_DISTRO: [noetic, jammy]
ROS_DISTRO: [noetic, one]
runs-on: ubuntu-latest
permissions:
packages: write
Expand Down Expand Up @@ -58,8 +58,9 @@ jobs:
file: .docker/Dockerfile
build-args: |
ROS_DISTRO=${{ matrix.ROS_DISTRO }}
BASE_DOCKER_NAME=${{ matrix.ROS_DISTRO == 'one' && 'jammy' || ${matrix.ROS_DISTRO} }}
MUJOCO_VERSIONS=${{ env.MUJOCO_VERSIONS }}
IMAGE_PREFIX=${{ matrix.ROS_DISTRO == 'jammy' && 'ubiagni/' || '' }}
IMAGE_PREFIX=${{ matrix.ROS_DISTRO == 'one' && 'ubiagni/' || '' }}
push: true
no-cache: ${{ steps.apt.outputs.no_cache || github.event_name == 'workflow_dispatch' }}
cache-from: type=registry,ref=${{ env.IMAGE }}
Expand Down

0 comments on commit d81262b

Please sign in to comment.