Add hook for redirect function in ServeHTTP #939
Closed
+61
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aharshit29
force-pushed
the
redirect-event-hook
branch
from
eb2e43b to
5f8ea9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To migrate direct callers of edge-gateway to api-gateway-http, a flipr controlled gate is needed. This PR adds a hook in Zanzibar Router's ServeHTTP function so that a redirect function can be plugged in, to redirect the requests (received for a particular endpoint) to api-gateway-http instead of passing through edge-gateway.
This cannot be done at middleware level as ServeHTTP function also emits endpoint metrics which should not be emitted if the requests are being served by api-gateway-http.