Update test results without depending on data from parent test task #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnoah1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes within the bazel-bsp are resulting in blank parent ID/build target ID values for test case results. Issue has been documented here (https://youtrack.jetbrains.com/issue/BAZEL-1585) and is prioritized for this release cycle.
This extension currently depends on those fields to update pass/fail status for individual test cases.
In order to unblock updating this extension to the latest bazel-bsp version, this PR includes a workaround to look for the test case under each target in the run. Since this is less explicit than the prior approach, there is potential for collisions if the same test case appears in multiple targets in the same run. However, this is not a typical expected scenario that users are likely to face in our setup, so we can proceed with this temporarily for now and revert to the prior approach once the upstream issue has been addressed.