Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show setup message when no targets returned from sync #15

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

mnoah1
Copy link
Collaborator

@mnoah1 mnoah1 commented Jun 28, 2024

When a sync completes and returns no targets, it's likely that the user needs to make adjustments to their .bazelproject file.

This change adds guidance for the user to resolve issues and re-sync:

  • When no targets are returned, error message shown immediately below the root item, with access to .bazelproject file. This only supports one line, so we can't include full details here.
  • Detailed instructions will be surfaced at the top of the .bazelproject file, and in the lower test results panel:

image
image

@mnoah1 mnoah1 marked this pull request as ready for review June 28, 2024 19:51
Copy link
Contributor

@JamyDev JamyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

src/test-explorer/resolver.ts Outdated Show resolved Hide resolved
Co-authored-by: Jamy Timmermans <[email protected]>
@mnoah1 mnoah1 merged commit a962066 into main Jul 1, 2024
4 checks passed
@mnoah1 mnoah1 deleted the no-targets-returned branch July 1, 2024 18:52
@mnoah1 mnoah1 mentioned this pull request Jul 2, 2024
shuklahy pushed a commit that referenced this pull request Jul 2, 2024
## What's Changed
* Use readFile instead of openTextDocument for regex test case discovery
by @mnoah1 in #13
* Add getting started docs by @mnoah1 in
#12
* Adjust notifications during sync by @mnoah1 in
#14
* Show setup message when no targets returned from sync by @mnoah1 in
#15
* Adjustments to Python test discovery by @mnoah1 in
#17
* Add results from parameterized tests to parent by @mnoah1 in
#16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants