-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go.mod and github test to go 1.21 #899
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #899 +/- ##
==========================================
- Coverage 88.78% 88.54% -0.24%
==========================================
Files 43 43
Lines 4440 4505 +65
==========================================
+ Hits 3942 3989 +47
- Misses 379 394 +15
- Partials 119 122 +3
☔ View full report in Codecov by Sentry. |
26f1eef
to
af13a56
Compare
@@ -1,6 +1,6 @@ | |||
module github.com/uber/tchannel-go | |||
|
|||
go 1.17 | |||
go 1.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be 1.20 - see https://github.com/uber-go/fx/pull/1111/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh yea. Good callout. @zhiyipanuber can you patch this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually talked to @rabbbit and @zhiyipanuber offline, this should be fine for now as this future code won't build with version lower than 1.20.0.
This updates go.mod files to use Go 1.21.
It also updates the CI to use 1.21 to test.