Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.mod and github test to go 1.21 #899

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Conversation

zhiyipanuber
Copy link
Collaborator

This updates go.mod files to use Go 1.21.

It also updates the CI to use 1.21 to test.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 76.71% and project coverage change: -0.24% ⚠️

Comparison is base (0c11cc2) 88.78% compared to head (6c64580) 88.54%.
Report is 4 commits behind head on dev.

❗ Current head 6c64580 differs from pull request most recent head d35f2ed. Consider uploading reports for the commit d35f2ed to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #899      +/-   ##
==========================================
- Coverage   88.78%   88.54%   -0.24%     
==========================================
  Files          43       43              
  Lines        4440     4505      +65     
==========================================
+ Hits         3942     3989      +47     
- Misses        379      394      +15     
- Partials      119      122       +3     
Files Changed Coverage Δ
outbound.go 87.28% <33.33%> (+0.14%) ⬆️
messages.go 91.58% <50.00%> (-6.27%) ⬇️
mex.go 72.88% <76.00%> (+0.36%) ⬆️
connection.go 85.49% <88.88%> (+0.50%) ⬆️
inbound.go 81.50% <100.00%> (-0.89%) ⬇️
relay.go 85.77% <100.00%> (+0.06%) ⬆️
relay_messages.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AllenLuUber AllenLuUber merged commit e0354b9 into dev Aug 21, 2023
1 check passed
@AllenLuUber AllenLuUber deleted the zhiyi.pan/upgrade-go branch August 21, 2023 20:48
@@ -1,6 +1,6 @@
module github.com/uber/tchannel-go

go 1.17
go 1.21
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh yea. Good callout. @zhiyipanuber can you patch this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually talked to @rabbbit and @zhiyipanuber offline, this should be fine for now as this future code won't build with version lower than 1.20.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants