Add MaxCloseTime as a graceful close timeout #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #724 +/- ##
==========================================
+ Coverage 87.24% 87.92% +0.68%
==========================================
Files 40 40
Lines 4068 4075 +7
==========================================
+ Hits 3549 3583 +34
+ Misses 395 374 -21
+ Partials 124 118 -6
Continue to review full report at Codecov.
|
witriew
approved these changes
Feb 1, 2019
Currently, a connection waits until all calls are complete before moving to the "closed" state. However, if there are stuck calls (either because of long-running user calls, or because of issues where calls are not tracked properly), the connection can remain open forever and leak resources. Add a MaxCloseTime which will close the connection after spending a maximum amount of time in a close state. Rather than add another close branch, reuse the existing connection error branch (by using read deadlines). We now also ensure checkExchanges will move the connection to the closed state once exchanges are closed -- important since relay calls are not forcefully shutdown in `closeNetwork`, so we wouldn't actually change state previously. Fixes #699
prashantv
force-pushed
the
close_timeout
branch
from
8acf3fe to
aad417b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a connection waits until all calls are complete before
moving to the "closed" state. However, if there are stuck calls
(either because of long-running user calls, or because of issues
where calls are not tracked properly), the connection can remain
open forever and leak resources.
Add a MaxCloseTime which will close the connection after spending
a maximum amount of time in a close state.
Rather than add another close branch, reuse the existing connection
error branch (by using read deadlines).
We now also ensure checkExchanges will move the connection to the closed
state once exchanges are closed -- important since relay calls are not
forcefully shutdown in
closeNetwork, so we wouldn't actually changestate previously.
Fixes #699