Simplify coverage and lint actions v2 #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Subsumes #434 |
ajfriend
requested review from
nrabinowitz,
dfellis,
isaacbrodsky and
jongbinjung
dfellis
approved these changes
Dec 29, 2024
isaacbrodsky
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate tests between Python and Cython APIs; see the
tests/readme.md. We do this because we are currently not at 100% coverage for the Cython API (note: which isn't currently externally supported), but we are at 100% coverage for the Python API.We were previously using a coverage service, but ran into issues often enough that it seems easier to just setup a test requiring 100% coverage on the Python API. In the future, we'll also require 100% on the Cython API.
This PR also adds some tests to get back to 100% after adding the experimental polyfill algorithm in #432