Remove gj #316
Merged
Remove gj #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajfriend
added a commit
that referenced
this pull request
Dec 30, 2023
* polygons_to_cells * Helpers for cells_to_geojson and geojson_to_cells * ValueError * Remove gj (#316) * Remove geojson logic from cell_to_boundary and directed_edge_to_boundary * fix a warning about return values in tests from pytest * Remove geo_json logic from cells_to_multi_polygon * remove some unused tests * add back in polygons_to_cells * actions/[email protected] * Solution copied from actions/setup-python#544 * playing around with polygons * make a directory * bah * start migrating `h3.Polygon` to `H3Poly` * migrate most * finish migrating * H3MultiPoly repr * shape_to_cells and cells_to_shape * tests: polygon_to_cells to shape_to_cells * finish migrating tests * update util.py and example * notes * bah * fix lint * fix * remove X_to_shape * run tests * run other CIs too * don't use f-string * test update * change errors per review * remove unused per review * fix lint * test run * fix exclude logic in tests * " to ' in yaml * move conversion logic to geo_to_cells function * linting * few more tests * lint * clean up * complete tests * group geojson/polygon tests into a folder * move MockGeoInterface into the file that uses it * move test_input_format to its own file, since it has a lot of helper functions not used elsewhere * test module description * rename _polygon.py to _h3shape.py * make H3Shape an ABC * shape -> h3shape * geos to polys * rename geo files to latlng * docstrings * __init__.py * lint * notebooks * more interface tests * notebooks * merp * clean up geo_to_h3shape() * simplify sydney coords * simplify far east test * simplify sf coords * tuples * geo interface tests * more interface tests * clean up maine lat/lngs * messed up lat/lng order in tests. this mistake gets made all the time! * expand geo_to_h3shape test * plotting with contextily and geoviews * reprs for H3Shape objects should work better with geopandas * different representations of the same information. which is best? * us "loopcode" in H3Poly and H3MultiPoly reprs * set tight=True as default * can't use f-strings in python 3.5 * notebooks * basic plotting * plotting * plotting * tutorial notebook * cleaning up * clean up geoviews example * remove geoviews example * todos * reworking tutorial order * notebook dump * cleaner * move tutorial * Update src/h3/api/_api_template.py Co-authored-by: Jongbin Jung <[email protected]> * Update src/h3/api/_api_template.py Co-authored-by: Isaac Brodsky <[email protected]> * Update src/h3/api/_api_template.py Co-authored-by: Jongbin Jung <[email protected]> * setting loops * bug and lint --------- Co-authored-by: Isaac Brodsky <[email protected]> Co-authored-by: Jongbin Jung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.