Set view tree owners #606
Merged
Set view tree owners #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbarr21
force-pushed
the
jb/set-viewtree-owners
branch
from
ed75874 to
53c718b
Compare
sanchezz93
approved these changes
Aug 7, 2023
psteiger
requested changes
Aug 7, 2023
android/libraries/rib-android/src/test/kotlin/com/uber/rib/core/RibActivityTest.kt
Show resolved
Hide resolved
psteiger
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set view tree owners in
RibActivity#onCreate. Since it adds the root RIB's view to theandroid.R.id.contentview usingActivity#addView(View)instead of calling AppCompatActivity#setContentView(View) which already handles this.