-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests on JDK 21 #826
Run tests on JDK 21 #826
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #826 +/- ##
============================================
+ Coverage 86.75% 86.77% +0.01%
Complexity 1870 1870
============================================
Files 74 74
Lines 6178 6178
Branches 1202 1202
============================================
+ Hits 5360 5361 +1
Misses 406 406
+ Partials 412 411 -1 ☔ View full report in Codecov by Sentry. |
Converted this one to a draft again as I'd like to get rid of at least some of the copy-pasting in the Gradle build files |
This is now ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit, but LGTM otherwise!
It looks like most of our tests pass on JDK 21. Exceptions are the JSpecify generics tests, which rely on an API that changed in JDK 21 (see #827), and the JarInfer tests, as it looks like WALA does not yet support running on JDK 21 (see #829). Core NullAway support (ignoring the experimental/WIP JSpecify mode) should be working. This PR adds test configs so that we run tests on JDK 21 wherever possible. We update our Jacoco and Mockito versions to make this work.
We also take the opportunity to move some common test configuration code to the
nullaway.java-test-conventions.gradle
file, which previously just held configuration for Jacoco.