Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on JDK 21 #826

Merged
merged 14 commits into from
Sep 5, 2023
Merged

Run tests on JDK 21 #826

merged 14 commits into from
Sep 5, 2023

Conversation

msridhar
Copy link
Collaborator

@msridhar msridhar commented Sep 4, 2023

It looks like most of our tests pass on JDK 21. Exceptions are the JSpecify generics tests, which rely on an API that changed in JDK 21 (see #827), and the JarInfer tests, as it looks like WALA does not yet support running on JDK 21 (see #829). Core NullAway support (ignoring the experimental/WIP JSpecify mode) should be working. This PR adds test configs so that we run tests on JDK 21 wherever possible. We update our Jacoco and Mockito versions to make this work.

We also take the opportunity to move some common test configuration code to the nullaway.java-test-conventions.gradle file, which previously just held configuration for Jacoco.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (fcaf39e) 86.75% compared to head (bcabfb9) 86.77%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #826      +/-   ##
============================================
+ Coverage     86.75%   86.77%   +0.01%     
  Complexity     1870     1870              
============================================
  Files            74       74              
  Lines          6178     6178              
  Branches       1202     1202              
============================================
+ Hits           5360     5361       +1     
  Misses          406      406              
+ Partials        412      411       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar marked this pull request as ready for review September 4, 2023 18:01
@msridhar msridhar requested a review from lazaroclapp September 4, 2023 18:01
@msridhar msridhar mentioned this pull request Sep 4, 2023
@msridhar msridhar marked this pull request as draft September 4, 2023 20:21
@msridhar
Copy link
Collaborator Author

msridhar commented Sep 4, 2023

Converted this one to a draft again as I'd like to get rid of at least some of the copy-pasting in the Gradle build files

@msridhar msridhar marked this pull request as ready for review September 5, 2023 15:46
@msridhar
Copy link
Collaborator Author

msridhar commented Sep 5, 2023

This is now ready for review again

Copy link
Collaborator

@lazaroclapp lazaroclapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but LGTM otherwise!

@msridhar msridhar enabled auto-merge (squash) September 5, 2023 19:18
@msridhar msridhar merged commit f98bc4b into uber:master Sep 5, 2023
9 checks passed
@msridhar msridhar deleted the basic-jdk-21-supoprt branch September 5, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants