Code

Incorporate feedback from #130#138

Code

Merged

ZacSweers merged 25 commits intomasteruber/AutoDispose:masterfrom z/feedbackuber/AutoDispose:z/feedbackCopy head branch name to clipboardDec 3, 2017

+569-244

Commits

Commits on Nov 18, 2017

• Remove unnecessary synchronized blocks

  ZacSweers

  committed
  bd22bc2

• Fix introspection typo

  ZacSweers

  committed
  caf904a

• Fix introspection typo in observer

  ZacSweers

  committed
  79e6dbf

• Make AutoDispose ScopeHandlers final

  ZacSweers

  committed
  94212eb

• Extract DisposableMaybeObserver and setOnce first

  ZacSweers

  committed
  9bf1993

• Opportunistic tweak of RxErrorsRule

  Show description for 53eef69
  ZacSweers

  committed
  53eef69

• Lazyset disposables in scope callbacks to prevent double subscriptions

  Show description for 7ac1488
  ZacSweers

  committed
  7ac1488

• Inline lazyDispose() methods

  Show description for d564b40
  ZacSweers

  committed
  d564b40

• Wire up HalfSerializer to observer and subscribers

  Show description for cb432a8
  ZacSweers

  committed
  cb432a8

• Fix ViewAttachEventsObservable not observing observer contract

  ZacSweers

  committed
  07f0f1e

• Fix LifecycleEventsObservable not observing observer contract

  ZacSweers

  committed
  ec190c0

• Inline lazyDispose() impl

  ZacSweers

  committed
  9606ae4

• Remove unnecessary nullcheck in request()

  ZacSweers

  committed
  b38d03f

• Suppress nullaway false positive

  ZacSweers

  committed
  7705288

• Initialize atomic throwables inline

  ZacSweers

  committed
  daad41b

• Use deferred requesting

  ZacSweers

  committed
  500f337

Commits on Nov 27, 2017

• Call delegate.onSubscribe() first, remove callSubscribeIfNecessary

  ZacSweers

  committed
  e7e1b87

• Check if observer is disposed in lifecycle events

  ZacSweers

  committed
  a0d8556

• Check if listener is disposed in viewattacheventsobservable

  ZacSweers

  committed
  22ba683

• Remove private to avoid synthetic accessor

  ZacSweers

  committed
  959fe09

• Use non-rx-internal subscriptionhelper APIs

  ZacSweers

  committed
  6a45aa4

• Opportunistic fix missing synchronized in overridden method

  ZacSweers

  committed
  44b362f

• Remove callSubscribeIfNecessary, avoid duplicate subscribes

  ZacSweers

  committed
  ba8bd87

• Switch orders of lazySet + dispose to flush

  ZacSweers

  committed
  9c3edf4

• Optimize lifecycle error propagation a bit

  Show description for 3b87876
  ZacSweers

  committed
  3b87876