Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unbound() shorthand to ScopeProvider itself #125

Merged
merged 5 commits into from
Nov 8, 2017
Merged

Conversation

ZacSweers
Copy link
Collaborator

This makes UNBOUND a singleton instance on ScopeProvider itself, allowing for its use in regular non-test code too and a more flexible shorthand.

Since unbound-ness is a an official scope, this is a shortcut that's more clear than Maybe.never()
@ZacSweers ZacSweers self-assigned this Oct 31, 2017
@ZacSweers ZacSweers requested a review from jbarr21 October 31, 2017 08:35
@ZacSweers
Copy link
Collaborator Author

@jbarr21 can you take a look at this?

@jbarr21
Copy link
Collaborator

jbarr21 commented Nov 8, 2017

+1

@ZacSweers ZacSweers merged commit 304fdff into master Nov 8, 2017
@ZacSweers ZacSweers deleted the z/UNBOUND branch November 8, 2017 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants