Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxLifecycle interop module #118

Merged
merged 16 commits into from
Oct 22, 2017
Merged

RxLifecycle interop module #118

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
d078017
RX lifecycle interop module added for autodipose
bangarharshit Oct 21, 2017
159205a
Added pom artifact
bangarharshit Oct 21, 2017
25f3868
Renamed package, fixed javadoc and addressed other review comments
bangarharshit Oct 21, 2017
19a0445
Fixed lifecycle everywhere and moved rxlifecycle to misc in dependenc…
bangarharshit Oct 21, 2017
12840a9
Fixed javadoc
bangarharshit Oct 21, 2017
335f22b
Renamed RXLifecycle to RxLifecycle and method name fix
bangarharshit Oct 21, 2017
5f2be30
Renamed depdencies in dependency.gradle and removed class from javadoc
bangarharshit Oct 21, 2017
11f6174
Renamed methods in RXLifecycle to from() for consistency
bangarharshit Oct 21, 2017
ce14957
Added javadoc for individual methods
bangarharshit Oct 21, 2017
c38dd9c
Removed double space
bangarharshit Oct 21, 2017
f33e1c7
Fixed checkstyle for test
bangarharshit Oct 21, 2017
06be7fb
fixed exception name
bangarharshit Oct 21, 2017
51d7989
API replaced with implementation to avoid transitive compile time dep…
bangarharshit Oct 21, 2017
7182d54
Reverted the incorrect api
bangarharshit Oct 21, 2017
e463be6
Added more javadoc in package-info.java and license header to all the…
bangarharshit Oct 22, 2017
7f3e1a8
Fixed javadoc
bangarharshit Oct 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions autodispose-rxlifecycle/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/*
* Copyright (C) 2017. Uber Technologies
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

buildscript {
repositories {
jcenter()
Expand Down
16 changes: 16 additions & 0 deletions autodispose-rxlifecycle/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
#
# Copyright (C) 2017. Uber Technologies
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

POM_NAME=AutoDispose (RxLifecycle Interop)
POM_ARTIFACT_ID=autodispose-rxlifecycle
POM_PACKAGING=jar
16 changes: 16 additions & 0 deletions ...ose-rxlifecycle/src/main/java/com/ubercab/autodispose/rxlifecycle/RxLifecycleInterop.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/*
* Copyright (c) 2017. Uber Technologies
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.ubercab.autodispose.rxlifecycle;

import com.trello.rxlifecycle2.LifecycleProvider;
Expand Down
4 changes: 3 additions & 1 deletion autodispose-rxlifecycle/src/main/java/com/ubercab/autodispose/rxlifecycle/package-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
*/

/**
* Interop for RxLifecycle.
* Interop for RxLifecycle. It could understand RxLifecycle's
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can phrase this better, doesn't have to be too wordy. Let's do

AutoDispose extensions for interop with RxLifecycle. This namely supports {@link LifecycleProvider}.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed - 7f3e1a8

* LifecycleProvider mechanics, which in turn lend support to different
* components such as RxActivity. It does so by providing converters to retrieve ScopeProvider.
*/
@com.uber.javaxextras.FieldsMethodsAndParametersAreNonNullByDefault
package com.ubercab.autodispose.rxlifecycle;
Expand Down
16 changes: 16 additions & 0 deletions ...rxlifecycle/src/test/java/com/ubercab/autodispose/rxlifecycle/RxLifecycleInteropTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/*
* Copyright (c) 2017. Uber Technologies
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.ubercab.autodispose.rxlifecycle;

import com.uber.autodispose.AutoDispose;
Expand Down
16 changes: 16 additions & 0 deletions ...-rxlifecycle/src/test/java/com/ubercab/autodispose/rxlifecycle/TestLifecycleProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
/*
* Copyright (c) 2017. Uber Technologies
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.ubercab.autodispose.rxlifecycle;

import com.trello.rxlifecycle2.LifecycleProvider;
Expand Down